"Could not find destination in the navigation graph, ignoring the deep link from Intent" for deep link in nested navigation [154532067]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Apr 21, 2020 07:20AM

Component used: Navigation

Version used: 2.2.2

Devices/Android versions reproduced on: Emulator Android R, OnePlus 7 with Android 10

The issue appeared in 2.2.2, 2.2.1 works just fine. Error log:

I/NavController: Could not find destination com.my.app:id/main_navigation in the navigation graph, ignoring the deep link from Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x1040c000 pkg=com.my.app cmp=com.my.app/com.my.app.MainActivity (has extras) }

This log appears TWICE, so both graphs failed while lookup. In version 2.2.1 this log appeared once, as expected, for the nested graph.

The issue here is that in main_navigation i have other navigation graph for intro flow (splash screen, onboarding etc). If in main_navigation i have only fragments - everything works fine

Scenario to reproduce problem on attached project

Run app
Click "go to main page"
Click "Create notification"
Now hide the application and click notification

Pending intent in notification should point to main page, but it can't. Why? Because method findInvalidDestinationDisplayNameInDeepLink is looking for deep link handler twice. Once in proper main_navigation. But the second time - it is looking for it in intro_navigation, which doesn't have destination we are looking for. The changed line that broke things is graph.findNode(destinationId, false);. And it seems reasonable to me - intro_navigation can't find proper node, but it's parent can. I can confirm that evaluating graph.findNode(destinationId, true); returns proper node which is expected behavior.

Please ask if i can provide you with more information. Full reproduction sample provided.

TestApplication.zip

148 KB

Download

Comments

il...@google.com <il...@google.com> #2Apr 21, 2020 04:25PM

you explicitly mention "brew", which is nothing to do with us, but imply that when you downloaded "platform tools" (presumably from developer.google.com), that worked. so i think you need to talk to the (home?)brew folks...

[Deleted User] <[Deleted User]> #3Apr 21, 2020 09:39PM

No by brew I meant that my platform tools recently updated. I ran brew through an update and as a part of the update it updates all the packages you've installed using brew, and android platfrom tools is one of them. Brew doesn't let you downgrade platform tools version, and neither does the Android website. But I found the previous version of platform tools on another website and uninstalled the 34.0 version and used the 33.0.3 and it was working. So no I wasn't implying that brew broke it, I shouldn't have even included brew in my explanation, just explaining that I recently updated the platform tools and that's when this issue came up.

il...@google.com <il...@google.com> #4Apr 21, 2020 10:05PM

Accepted by il...@google.com.

In fact, I just installed the latest Android Platform Tools from

https://developer.android.com/studio/releases/platform-tools and it has the same issue.

ap...@google.com <ap...@google.com> #5Apr 21, 2020 10:59PM

did you adb kill-server to ensure you're actually running the new one?

il...@google.com <il...@google.com> #6Apr 22, 2020 12:00AM

Marked as fixed.

I forgot to mention I am on Mac.

[Deleted User] <[Deleted User]> #7Apr 23, 2020 05:43PM

Yes I did that.

an...@google.com <an...@google.com> #8May 26, 2020 09:07PM

Are you not gonna fix it even though it was working in the 33.0.3 release?

il...@google.com <il...@google.com> #9May 27, 2020 05:37PM

Are you not gonna fix it even though it was working in the 33.0.3 release?

at the moment, this is at best on the "maybe there's the a problem?" pile. if macOS was as broken as you suggest, we'd probably have heard more than one complaint by now. so in the meantime, there are lots of other more bugs to look at, that we're already convinced are real.

you can make this bug more convincing by trying to work out what the actual variable is --- is it some specific model of mac? is it only some specific macOS versions? android versions? is there anything interesting in logcat?

dk...@fundrise.com <dk...@fundrise.com> #10Aug 18, 2020 08:39PM

If you want to know specific Mac's and MacOS versions it's broken on, I don't have any time for that, nor do I have the equipment for that, I have one Macbook. I can let you know I am on MacOS version 12.6.3 and am on a MacBook Pro (16-inch, 2019). As far as it being broken on other platforms, I may have time to test on Windows and seem if the platform tools on Windows has the same issue in the latest version. And I don't know how logcat would show any issues if the adb shell command is working just fine over USB, it's just the install function that isn't working and is hanging. I haven't tested all the adb functions nor do I use them all, so no I wasn't suggesting all of ADB was broken on Mac either. I specifically mentioned the adb install command.

il...@google.com <il...@google.com> #11Aug 18, 2020 08:47PM

Also the fact that it was working in the previous platform tools release, and then you assuming that I would make a bug up just because is pretty far out there. It was working and I just noticed it because platform tools was recently updated. As far as specific Android versions, so far I have tested on Android 7 and Android 9 and it still works on Android 7 but does not work on Android 9. Those are the two main Android versions I work on so as far as other Android versions it working or not, I don't know.