Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
since these are in public API (:/) we need to do this in 1.2
[Deleted User] <[Deleted User]> #3
since it is already marked as deprecated, we can probably do it by now.
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
il...@google.com <il...@google.com> #6
We've fixed this internally and it'll be available in Navigation 2.3.0-alpha05. We're still evaluating a potential 2.2.X release (which would include this release if we did one).
[Deleted User] <[Deleted User]> #7
Thanks!
an...@google.com <an...@google.com> #8
il...@google.com <il...@google.com> #9
We've decided to release a Navigation 2.2.3 bug fix release and will be including this change in that release.
dk...@fundrise.com <dk...@fundrise.com> #10
Guys, 2.3.0 doesn't have this fix included
il...@google.com <il...@google.com> #11
Re #10 - it definitely does. Please file a new issue with a sample project that reproduces any issue you're having with Navigation 2.3.0.
Description
Component used: Navigation
Version used: 2.2.2
Devices/Android versions reproduced on: Emulator Android R, OnePlus 7 with Android 10
The issue appeared in 2.2.2, 2.2.1 works just fine. Error log:
This log appears TWICE, so both graphs failed while lookup. In version 2.2.1 this log appeared once, as expected, for the nested graph.
The issue here is that in
main_navigation
i have other navigation graph for intro flow (splash screen, onboarding etc). If in main_navigation i have only fragments - everything works fineScenario to reproduce problem on attached project
Pending intent in notification should point to main page, but it can't. Why? Because method
findInvalidDestinationDisplayNameInDeepLink
is looking for deep link handler twice. Once in propermain_navigation
. But the second time - it is looking for it inintro_navigation
, which doesn't have destination we are looking for. The changed line that broke things isgraph.findNode(destinationId, false);
. And it seems reasonable to me -intro_navigation
can't find proper node, but it's parent can. I can confirm that evaluatinggraph.findNode(destinationId, true);
returns proper node which is expected behavior.Please ask if i can provide you with more information. Full reproduction sample provided.