"Could not find destination in the navigation graph, ignoring the deep link from Intent" for deep link in nested navigation [154532067]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Apr 21, 2020 07:20AM

Component used: Navigation

Version used: 2.2.2

Devices/Android versions reproduced on: Emulator Android R, OnePlus 7 with Android 10

The issue appeared in 2.2.2, 2.2.1 works just fine. Error log:

I/NavController: Could not find destination com.my.app:id/main_navigation in the navigation graph, ignoring the deep link from Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x1040c000 pkg=com.my.app cmp=com.my.app/com.my.app.MainActivity (has extras) }

This log appears TWICE, so both graphs failed while lookup. In version 2.2.1 this log appeared once, as expected, for the nested graph.

The issue here is that in main_navigation i have other navigation graph for intro flow (splash screen, onboarding etc). If in main_navigation i have only fragments - everything works fine

Scenario to reproduce problem on attached project

Run app
Click "go to main page"
Click "Create notification"
Now hide the application and click notification

Pending intent in notification should point to main page, but it can't. Why? Because method findInvalidDestinationDisplayNameInDeepLink is looking for deep link handler twice. Once in proper main_navigation. But the second time - it is looking for it in intro_navigation, which doesn't have destination we are looking for. The changed line that broke things is graph.findNode(destinationId, false);. And it seems reasonable to me - intro_navigation can't find proper node, but it's parent can. I can confirm that evaluating graph.findNode(destinationId, true); returns proper node which is expected behavior.

Please ask if i can provide you with more information. Full reproduction sample provided.

TestApplication.zip

148 KB

Download

Comments

il...@google.com <il...@google.com> #2Apr 21, 2020 04:25PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

[Deleted User] <[Deleted User]> #3Apr 21, 2020 09:39PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

il...@google.com <il...@google.com> #4Apr 21, 2020 10:05PM

Accepted by il...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5Apr 21, 2020 10:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 96fc97e0e9f09ed2ea09bfed3610373ba18ef547
Author: Ian Lake <ilake@google.com>
Date: Tue Apr 21 15:05:30 2020

Fix deep linking when using nested start destinations

Ensure that findInvalidDestinationDisplayNameInDeepLink
correctly handles nested start destinations.

Test: new NavControllerTest passes
BUG: 154532067
Change-Id: I95b84ea1ca0f8901c3af5447a3f60fae29daa8d0

M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1291664

il...@google.com <il...@google.com> #6Apr 22, 2020 12:00AM

Marked as fixed.

We've fixed this internally and it'll be available in Navigation 2.3.0-alpha05. We're still evaluating a potential 2.2.X release (which would include this release if we did one).

[Deleted User] <[Deleted User]> #7Apr 23, 2020 05:43PM

Thanks!

an...@google.com <an...@google.com> #8May 26, 2020 09:07PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6205454677704704/#/history/all)
Created: 2020-05-26 21:05:07.312387+00:00
Changes: aosp/1291664

il...@google.com <il...@google.com> #9May 27, 2020 05:37PM

We've decided to release a Navigation 2.2.3 bug fix release and will be including this change in that release.

dk...@fundrise.com <dk...@fundrise.com> #10Aug 18, 2020 08:39PM

Guys, 2.3.0 doesn't have this fix included

il...@google.com <il...@google.com> #11Aug 18, 2020 08:47PM

Re #10 - it definitely does. Please file a new issue with a sample project that reproduces any issue you're having with Navigation 2.3.0.