"Could not find destination in the navigation graph, ignoring the deep link from Intent" for deep link in nested navigation [154532067]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Apr 21, 2020 07:20AM

Component used: Navigation

Version used: 2.2.2

Devices/Android versions reproduced on: Emulator Android R, OnePlus 7 with Android 10

The issue appeared in 2.2.2, 2.2.1 works just fine. Error log:

I/NavController: Could not find destination com.my.app:id/main_navigation in the navigation graph, ignoring the deep link from Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x1040c000 pkg=com.my.app cmp=com.my.app/com.my.app.MainActivity (has extras) }

This log appears TWICE, so both graphs failed while lookup. In version 2.2.1 this log appeared once, as expected, for the nested graph.

The issue here is that in main_navigation i have other navigation graph for intro flow (splash screen, onboarding etc). If in main_navigation i have only fragments - everything works fine

Scenario to reproduce problem on attached project

Run app
Click "go to main page"
Click "Create notification"
Now hide the application and click notification

Pending intent in notification should point to main page, but it can't. Why? Because method findInvalidDestinationDisplayNameInDeepLink is looking for deep link handler twice. Once in proper main_navigation. But the second time - it is looking for it in intro_navigation, which doesn't have destination we are looking for. The changed line that broke things is graph.findNode(destinationId, false);. And it seems reasonable to me - intro_navigation can't find proper node, but it's parent can. I can confirm that evaluating graph.findNode(destinationId, true); returns proper node which is expected behavior.

Please ask if i can provide you with more information. Full reproduction sample provided.

TestApplication.zip

148 KB

Download

Comments

il...@google.com <il...@google.com> #2Apr 21, 2020 04:25PM

Oh I forgot to mention that I thought it might be connected to this issue: https://issuetracker.google.com/issues/243778589. But after trying 2.5.2 I can say that the issue persists.

[Deleted User] <[Deleted User]> #3Apr 21, 2020 09:39PM

Please provide a minimal sample project along with the minimal steps to recreate the issue in the project.

il...@google.com <il...@google.com> #4Apr 21, 2020 10:05PM

Accepted by il...@google.com.

Sorry for the delay. I got a working example here: https://github.com/Del-S/issues. The project is set up to crash when navigating to ThirdFragment (nested nav graph) with poping the graph.

I poked into it a little bit and it seems to be connected to SafeArgs gradle plugin. When safe args is used to navigate to ThirdFragment (with nested graph poped) it will try to recreate te parent but there were no arguments passed so it crashes.

Steps to reproduce:

Navigate from Second Fragment to Child nav graph (with non-nullable parameters).
Navigate to Third fragment using SafeArgs and the app crashes.

Crash log:

Process: cz.dels.issues, PID: 1743
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:352)
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:342)
at androidx.navigation.NavArgument.verify(NavArgument.kt:76)
at androidx.navigation.NavDestination.addInDefaultArgs(NavDestination.kt:502)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1865)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at cz.dels.issues.SecondFragment.onViewCreated$lambda-0(SecondFragment.kt:38)
at cz.dels.issues.SecondFragment.$r8$lambda$XDYnOS_cYrafiNQ5rcCu1WCn0IE(Unknown Source:0)
at cz.dels.issues.SecondFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:2)

Note: If in step 2 SaveArgs is not used then navigation works correctly. More information is here: https://github.com/Del-S/issues/blob/master/app/src/main/java/cz/dels/issues/SecondFragment.kt#L37.

ap...@google.com <ap...@google.com> #5Apr 21, 2020 10:59PM

Ups a typo: Navigate from ~~Second~~ First Fragment to Child nav graph (with non-nullable parameters).

Note: sorry for the spam but I am not able to edit my own comment.

il...@google.com <il...@google.com> #6Apr 22, 2020 12:00AM

Marked as fixed.

This has been fixed and will be available in navigation 2.6.0-alpha08

[Deleted User] <[Deleted User]> #7Apr 23, 2020 05:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6b358154b794a0456b089ac8e548bfb830dd6c22
Author: Clara Fok <clarafok@google.com>
Date: Tue Mar 14 17:56:12 2023

Fix missing non-nullable arg when rebuilding hierarchy

When navigating with NavDirections, args is populated with an empty bundle. This causes issue when we rebuild parent hierarchy while adding a new entry to NavBackStack. If the Entry being rebuilt contains a non-nullalbe arg, i.e. Long, this empty bundle will cause an exception.

Test: ./gradlew navigation:navigation-runtime:cC
Bug: 249988437
Change-Id: I5c8ce739ad9a3428c8a8de13eae391bfff0db5df

M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/2488855

an...@google.com <an...@google.com> #8May 26, 2020 09:07PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-runtime:2.6.0-alpha08

il...@google.com <il...@google.com> #9May 27, 2020 05:37PM

We've decided to release a Navigation 2.2.3 bug fix release and will be including this change in that release.

dk...@fundrise.com <dk...@fundrise.com> #10Aug 18, 2020 08:39PM

Guys, 2.3.0 doesn't have this fix included

il...@google.com <il...@google.com> #11Aug 18, 2020 08:47PM

Re #10 - it definitely does. Please file a new issue with a sample project that reproduces any issue you're having with Navigation 2.3.0.