Fragment getViewLifecycleOwner() is not stopped before the state is saved [154645875]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Apr 21, 2020 09:12PM

Component used: Fragment Version used: 1.3.0-alpha03

When the Activity receives a callback to onSaveInstanceState(), all Fragments have their Lifecycle stopped, ensuring that doing a FragmentTransaction between ON_START and ON_STOP is always safe.

However, the same is not done for the Lifecycle associated with the Fragment's getViewLifecycleOwner().

Both should be changed at the same time.

Comments

il...@google.com <il...@google.com> Apr 21, 2020 09:16PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #2Apr 21, 2020 11:07PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 25f416c1c0c96bff97d6c0cb7be2a24bfa696c26
Author: Ian Lake <ilake@google.com>
Date: Tue Apr 21 14:13:38 2020

Move viewLifecycleOwner to CREATED during onSaveInstanceState()

onSaveInstanceState() should change both the Fragment's
Lifecycle and the Fragment View's Lifecycle so that
it is always safe to do FragmentTransactions up until
ON_STOP for either Lifecycle.

Test: new FragmentArchLifecycleTest passes
BUG: 154645875
Change-Id: I8203de6c7eccbf726080e5f9f55cf89fcea2db9d

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentArchLifecycleTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentViewLifecycleOwner.java

https://android-review.googlesource.com/1292281

il...@google.com <il...@google.com> #3Apr 21, 2020 11:52PM

Marked as fixed.

This has been fixed internally and will be available in Fragment 1.3.0-alpha04.

an...@google.com <an...@google.com> #4May 27, 2020 12:29AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6552735953321984/#/history/all)
Created: 2020-05-27 00:27:09.780549+00:00
Changes: aosp/1292281

il...@google.com <il...@google.com> #5May 27, 2020 05:36PM

We've decided to release a Fragment 1.2.5 bug fix release and will be including this change in that release.

Issue 154645875