IssueTracker

• Artifact used: androidx.appcompat:appcompat
• Version: 1.2.0-beta01
• Theme: Theme.MaterialComponents.Light.NoActionBar
• Devices/Android versions: API 22 emulator

Issue

Setting the text appearance programmatically with TextViewCompat.setTextAppearance(TextView, Int) on an AppCompatEditText does not take into account theme attrs being used in ColorStateList as android:textColorHint (or android:textColorLink).

So on Lollipop, such a hint color is rendered as red (see screenshot).

Cause

Internally, it delegates to AppCompatTextHelper.onSetTextAppearance, which doesn't handle these two attributes - it only considers android:textColor:

if (Build.VERSION.SDK_INT < 23 && a.hasValue(R.styleable.TextAppearance_android_textColor)) {
    // If we're running on < API 23, the text color may contain theme references
    // so let's re-set using our own inflater
    final ColorStateList textColor = a.getColorStateList(R.styleable.TextAppearance_android_textColor);
    if (textColor != null) {
        mView.setTextColor(textColor);
    }
}

However, it does consider them in loadFromAttributes() so it seems like it's an oversight.

Feature request/bug fix

Update AppCompatTextHelper to handle theme attributes in CSLs for android:textColorHint and android:textColorLink in onSetTextAppearance() as it's done in loadFromAttributes().

Workaround

For folks in the meantime - call this too, after calling TextViewCompat.setTextAppearance().

/**
 * Reapply text color and textColorHint to support CSLs on Lollipop
 */
private fun TextView.resetTextColorsFromTextAppearance(@StyleRes textAppearance: Int) {
    if (Build.VERSION.SDK_INT >= 23) {
        // this fix is only necessary on API 21/22 because we need to load the ColorStateLists ourselves
        return
    }

    val attributes = intArrayOf(android.R.attr.textColor, android.R.attr.textColorHint)
    val typedArray = context.obtainStyledAttributes(textAppearance, attributes)
    val textColorRes = typedArray.getResourceId(attributes.indexOf(android.R.attr.textColor), -1)
    val textColorHintRes = typedArray.getResourceId(attributes.indexOf(android.R.attr.textColorHint), -1)
    typedArray.recycle()

    if (textColorRes != -1) {
        setTextColor(AppCompatResources.getColorStateList(context, textColorRes))
    }

    if (textColorHintRes != -1) {
        setHintTextColor(AppCompatResources.getColorStateList(context, textColorHintRes))
    }
}