[dev09] width & height modifiers remove opposite axis measurement constraints [154797971]

Fixed

Bug

Status Update

No update yet.

Description

ja...@google.com

created issue #1

Apr 23, 2020 10:47AM

This should fill the whole width of the container:

@Preview
@Composable
fun FillBug() {
Column(
modifier = Modifier
.fillMaxSize()
) {
Stack(
modifier = Modifier
.height(240.dp)
.fillMaxSize()
) {
Surface(
modifier = Modifier.fillMaxSize(),
color = Color.LightGray
) {
Text("This should fill the whole width")
}
}
}
}

image%20(1).png

96 KB

View

Download

Comments

so...@google.com <so...@google.com> #2Apr 23, 2020 10:50AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

Message last modified on Apr 23, 2020 10:56AM

Screenshot_1587638929.png

39 KB

View

Download

ja...@google.com <ja...@google.com> #3Apr 23, 2020 11:08AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

po...@google.com <po...@google.com> #4Apr 23, 2020 11:28AM

There is a bug in width and height which causes them to remove the incoming cross axis constraints when measuring their wrapped. Working on a fix.

ap...@google.com <ap...@google.com> #5Apr 24, 2020 01:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 448c4e77a029cd6ce0f63254a94d6100c0a7940b
Author: Mihai Popa <popam@google.com>
Date: Thu Apr 23 18:56:54 2020

Fix measurement in width and height modifiers

Before this CL, the width and height modifiers were measuring their
wrapped layout with [0, infinity) constraints in the opposite axis. This
CL fixes this behavior, by keeping the opposite axis constraints the
modifier is measured with.

Relnote: Fixed a bug in the width and height modifiers that was causing the wrapped layout to be measured with no opposite axis constraints.
Bug: 154797971
Test: LayoutSizeTest
Change-Id: I210b84ad765c3ab33e593f027245ab135dd036f4

M ui/ui-layout/api/0.1.0-dev11.txt
M ui/ui-layout/api/current.txt
M ui/ui-layout/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-layout/api/public_plus_experimental_current.txt
M ui/ui-layout/api/restricted_0.1.0-dev11.txt
M ui/ui-layout/api/restricted_current.txt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutSizeTest.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/LayoutSize.kt

https://android-review.googlesource.com/1294634

po...@google.com <po...@google.com> Apr 24, 2020 01:39PM

Marked as fixed.

Issue 154797971