Regression (2x) in measure for rectangle benchmark [155056091]

Obsolete

Bug

Status Update

No update yet.

Description

pa...@google.com

created issue #1

Apr 27, 2020 11:51AM

It seems that the previous layout that Box had was twice faster in measure than Column.

Given we plan the Box to be foundational component to build things with, we should probably see what we can do here.

Alert on dashboard:

https://androidx-perf.skia.org/t/?begin=1587746736&end=1587746737&subset=all

CLs in build: aosp/1287601

Note: the shared model benchmark surfaces things like this more because it recomposes all the rectangles even when one changes (because they share reference to one model entry from the foreach loop)

Comments

po...@google.com <po...@google.com> #2Sep 22, 2020 09:37AM

Never got around to posting the stacktraces + repro, sorry!

Simple repro:

@Composable
fun NoAssociatedStateIssueRepro() {
    val state = rememberModalBottomSheetState(ModalBottomSheetValue.HalfExpanded)
    ModalBottomSheetLayout(
        sheetState = state,
        sheetContent = { Box(Modifier.height(56.dp) }
    ) {

    }
}

The same crash can be provoked by having an empty sheet content:

@Composable
fun EmptySheetContentIssueRepro() {
    val state = rememberModalBottomSheetState(ModalBottomSheetValue.HalfExpanded)
    ModalBottomSheetLayout(
        sheetState = state,
        sheetContent = { }
    ) {

    }
}

This will crash with

java.lang.IllegalArgumentException: The initial value must have an associated anchor.
        at androidx.compose.material.SwipeableState.ensureInit$material_debug(Swipeable.kt:139)
        at androidx.compose.material.SwipeableKt$swipeable$3.invoke(Swipeable.kt:579)
        at androidx.compose.material.SwipeableKt$swipeable$3.invoke(Swipeable.kt:571)
        at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:75)
        at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:70)
        at androidx.compose.ui.Modifier$Element$DefaultImpls.foldIn(Modifier.kt:107)
        at androidx.compose.ui.ComposedModifier.foldIn(ComposedModifier.kt:47)
        at androidx.compose.ui.CombinedModifier.foldIn(Modifier.kt:149)
        at androidx.compose.ui.ComposedModifierKt.materialize(ComposedModifier.kt:70)
        at androidx.compose.ui.layout.LayoutKt$materializerOf$1.invoke-Deg8D_g(Layout.kt:174)
        at androidx.compose.ui.layout.LayoutKt$materializerOf$1.invoke(Layout.kt:173)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:130)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:46)
        at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetLayout$2.invoke-jYbf7pk(ModalBottomSheet.kt:399)
        at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetLayout$2.invoke(ModalBottomSheet.kt:269)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:149)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:46)
        at androidx.compose.material.ModalBottomSheetKt$BottomSheetStack$1$1$placeable$1.invoke(ModalBottomSheet.kt:344)
        at androidx.compose.material.ModalBottomSheetKt$BottomSheetStack$1$1$placeable$1.invoke(ModalBottomSheet.kt:344)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:121)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:46)
        at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2$1.invoke(SubcomposeLayout.kt:167)
        at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2$1.invoke(SubcomposeLayout.kt:167)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:121)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:46)
        at androidx.compose.runtime.ComposerKt.invokeComposable(Composer.kt:3422)
        at androidx.compose.runtime.ComposerImpl.composeContent$runtime_debug(Composer.kt:2604)
        at androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:348)
        at androidx.compose.runtime.Recomposer.composeInitial$runtime_debug(Recomposer.kt:697)
        at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_debug(Composer.kt:3028)
        at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_debug(Composer.kt:3028)
        at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:304)
        at androidx.compose.ui.layout.SubcomposeLayoutState.subcomposeInto(SubcomposeLayout.kt:184)
        at androidx.compose.ui.layout.SubcomposeLayoutState.access$subcomposeInto(SubcomposeLayout.kt:100)
        at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2.invoke(SubcomposeLayout.kt:160)
        at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2.invoke(SubcomposeLayout.kt:158)
        at androidx.compose.runtime.snapshots.SnapshotStateObserver.withNoObservations(SnapshotStateObserver.kt:137)
        at androidx.compose.ui.node.OwnerSnapshotObserver.withNoSnapshotReadObservation$ui_debug(OwnerSnapshotObserver.kt:49)
        at androidx.compose.ui.node.LayoutNode.withNoSnapshotReadObservation$ui_debug(LayoutNode.kt:1086)
        at androidx.compose.ui.layout.SubcomposeLayoutState.subcompose(SubcomposeLayout.kt:158)
        at androidx.compose.ui.layout.SubcomposeLayoutState.subcompose(SubcomposeLayout.kt:152)

pa...@google.com <pa...@google.com> #3Sep 23, 2020 03:33PM

Thanks Jossi, we'll take a look into it :)

Screenshot from 2020-09-23 16-27-54.png

175 KB

View

Download

Screenshot from 2020-09-23 16-28-56.png

109 KB

View

Download

ap...@google.com <ap...@google.com> #4Oct 8, 2020 09:32PM

Resetting assignee to `None` in preparation of the triage bash on Thursday June 17th. Please reach out to nickanthony@ if you have any questions.

po...@google.com <po...@google.com> #5Oct 13, 2020 11:29AM

Status: Won't Fix (Obsolete)

Any updates on this? It still crashes in 1.2.0-beta02

Issue 155056091

Description

Issue summary

Comments

po...@google.com <po...@google.com> #2Sep 22, 2020 09:37AM

pa...@google.com <pa...@google.com> #3Sep 23, 2020 03:33PM

ap...@google.com <ap...@google.com> #4Oct 8, 2020 09:32PM

po...@google.com <po...@google.com> #5Oct 13, 2020 11:29AM

Add comment

Issue metadata