Status Update
No update yet.
Comments
po...@google.com
Branch: androidx-main
commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024
[M2 text field] Apply background to decoration box
...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.
Fixes:
Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
pa...@google.com
There does not seem to be any improvement in that particular benchmark.
I was looking based on build ab/6852971
Attached screenshots of all the devices + one without the noisy ones. The point where is the cross-hair is the place with the build.
You can also take a look yourself here:
To pan and zoom please use the keyboard shortcuts (displayed on the left side of the UI with blue text)
ap...@google.com
Branch: androidx-master-dev
commit e7bf661e6433826be9ab75256bb2ca7ff259304d
Author: Mihai Popa <popam@google.com>
Date: Fri Sep 25 11:15:39 2020
Refactor Box for improved performance
The CL:
- updates the implementation of Box to reduce allocations and the number
of children traversals
- makes Box inline
- adds NestedBoxesBenchmark, which shows a 25% improvement after the
changes above
Relnote: Box was made an inline function.
Bug: 155056091
Test: ran BoxTest and NestedBoxesBenchmark
Change-Id: Ibce0c1940173f06c030fd1115b9badb692ceb05a
M compose/foundation/foundation-layout/api/current.txt
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/api/restricted_current.txt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Box.kt
A compose/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/NestedBoxesBenchmark.kt
A compose/integration-tests/src/main/java/androidx/ui/integration/test/foundation/NestedBoxesTestCase.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Swipeable.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/SubcomposeLayoutTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/BoundsTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/ModifierInfoTest.kt
po...@google.com
Since this is an old regression, and many performance improvements have happened in the past months, I will close this as obsolete. Nonetheless, I am a bit surprised my CL did not improve that benchmark.
Description
Given we plan the Box to be foundational component to build things with, we should probably see what we can do here.
Alert on dashboard:
CLs in build: aosp/1287601
Note: the shared model benchmark surfaces things like this more because it recomposes all the rectangles even when one changes (because they share reference to one model entry from the foreach loop)