Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 97cdcb47a0532a7666fb4a89ab5dc124eb128e0c
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed May 06 20:23:45 2020
DrawLayerModifier shape api simplification
Few changes:
1) outlineShape is not non-nullable with RectangleShape default value and renamed to just 'shape' as there is no reason to use both shape and outline terms
2) clipToOutline renamed to clip
3) clipToBounds removed as it doesn't make this use case any simpler in the world where default shape is already RectangleShape. so old drawLayer(clipToBounds = true) has the same behavior as new drawLayer(clip = true)
4) similar renamings are happened for all overloads like drawShadow(), clip() etc.
5) I didn't keep deprecated overload with replace-to as it is impossible to keep it together with the new api when you rename the variable but keep the same signature
6) but I removed old deprecated overloads for this methods, they were here for 4 released, so we can do so
Relnote: DrawLayer modifiers api has been changed: outlineShape renamed to shape and has the RectangleShape default value and now non-nullable; clipToOutline renamed to clip; clipToBounds removed as it is the same as clip == true with RectangleShape
Fixes: 155075735
Test: tests in ui-core
Change-Id: I7ef1155f6a1d93c41a98411f9e4632c4e18956e1
M ui/ui-core/api/0.1.0-dev12.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev12.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev12.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/samples/src/main/java/androidx/ui/core/samples/LayerModifierSamples.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/AndroidViewCompatTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/ClipTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/DrawLayerTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/DrawShadowTest.kt
M ui/ui-core/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-core/src/main/java/androidx/ui/core/Clip.kt
M ui/ui-core/src/main/java/androidx/ui/core/DrawLayerModifier.kt
M ui/ui-core/src/main/java/androidx/ui/core/DrawShadow.kt
M ui/ui-core/src/main/java/androidx/ui/core/LayerWrapper.kt
M ui/ui-core/src/main/java/androidx/ui/core/Opacity.kt
M ui/ui-core/src/main/java/androidx/ui/core/OutlineResolver.kt
M ui/ui-core/src/main/java/androidx/ui/core/RenderNodeLayer.kt
M ui/ui-core/src/main/java/androidx/ui/core/ViewLayer.kt
M ui/ui-material/src/main/java/androidx/ui/material/Surface.kt
https://android-review.googlesource.com/1305274
Branch: androidx-master-dev
commit 97cdcb47a0532a7666fb4a89ab5dc124eb128e0c
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed May 06 20:23:45 2020
DrawLayerModifier shape api simplification
Few changes:
1) outlineShape is not non-nullable with RectangleShape default value and renamed to just 'shape' as there is no reason to use both shape and outline terms
2) clipToOutline renamed to clip
3) clipToBounds removed as it doesn't make this use case any simpler in the world where default shape is already RectangleShape. so old drawLayer(clipToBounds = true) has the same behavior as new drawLayer(clip = true)
4) similar renamings are happened for all overloads like drawShadow(), clip() etc.
5) I didn't keep deprecated overload with replace-to as it is impossible to keep it together with the new api when you rename the variable but keep the same signature
6) but I removed old deprecated overloads for this methods, they were here for 4 released, so we can do so
Relnote: DrawLayer modifiers api has been changed: outlineShape renamed to shape and has the RectangleShape default value and now non-nullable; clipToOutline renamed to clip; clipToBounds removed as it is the same as clip == true with RectangleShape
Fixes: 155075735
Test: tests in ui-core
Change-Id: I7ef1155f6a1d93c41a98411f9e4632c4e18956e1
M ui/ui-core/api/0.1.0-dev12.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev12.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev12.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/samples/src/main/java/androidx/ui/core/samples/LayerModifierSamples.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/AndroidViewCompatTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/ClipTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/DrawLayerTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/DrawShadowTest.kt
M ui/ui-core/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-core/src/main/java/androidx/ui/core/Clip.kt
M ui/ui-core/src/main/java/androidx/ui/core/DrawLayerModifier.kt
M ui/ui-core/src/main/java/androidx/ui/core/DrawShadow.kt
M ui/ui-core/src/main/java/androidx/ui/core/LayerWrapper.kt
M ui/ui-core/src/main/java/androidx/ui/core/Opacity.kt
M ui/ui-core/src/main/java/androidx/ui/core/OutlineResolver.kt
M ui/ui-core/src/main/java/androidx/ui/core/RenderNodeLayer.kt
M ui/ui-core/src/main/java/androidx/ui/core/ViewLayer.kt
M ui/ui-material/src/main/java/androidx/ui/material/Surface.kt
Description
No description yet.