Status Update
Comments
si...@google.com <si...@google.com> #2
And create a non-compose app will just works fine.
si...@google.com <si...@google.com>
si...@google.com <si...@google.com>
si...@google.com <si...@google.com> #3
si...@google.com <si...@google.com> #4
Same issue here, app crashes on start when using android-gradle 7.1.0-alpha04 and AS Canary 4
si...@google.com <si...@google.com> #5
aurimas@, are you the right person for triaging Android Studio version-specific issues? I saw you upgraded AndroidX to Bumblebee Canary 3 last week. This bug report might be specific to Bumblebee Canary 4, I'm not certain.
si...@google.com <si...@google.com> #6
Tested this quickly locally, it seems that the studio template creates a project that crashes out of the box. Updating compose_version to 1.0.0-rc02
and kotlin-gradle-plugin to 1.5.10
fixed the crash for me locally. We likely want to update studio template to use the latest of compose and kotlin.
ap...@google.com <ap...@google.com> #7
Moving to studio component for triage.
This is a pretty bad user experience so ccing annachiarab@ to make sure this gets attention
si...@google.com <si...@google.com> #8
It is likely to be addressed ag/Iafc18b104ff77fcd513d35db224d48f3b915a4e3
Description
CoreTextField(EditorValue, (EditorValue) -> Unit) (in ui.text)
TextField(EditorValue, (EditorValue) -> Unit) (in ui.foundation)
TextField(TextFieldValue, (TextFieldValue) -> Unit) (in ui.foundation)
FilledTextField(TextFieldValue, (TextFieldValue) -> Unit) (in ui.material)
FilledTextField(String, (String) -> Unit) (in ui.material)
EditorValue is the most powerful API, where every aspect of the text field is controllable, but also more cumbersome to use.
TextFieldValue is middle-weight, with only string value and selection controllable, but still a bit cumbersome to use
String is the least powerful API, but also the most convenient and powerful enough to satisfy the overwhelming majority of use cases.
My suggestion is to refactor these overloads to have each one fit into one of two overloads:
1. EditorValue-based (cumbersome, powerful)
2. String-based (convenient, useful)
The string-based variants would have an `onSelectionChanged: (Selection) -> Unit` parameter, but would not allow for a selection to be *controlled* (hence the past tense on the parameter name).
It seems to me like the need to control or listen to the selection state are both somewhat rare, but the need to control it is even more so. On the other hand, the need to control the text value is virtually 100% of the time. As a result, adding the overhead of the selection controllability in the common case feels wrong, since the times you might want to do that, the more powerful EditorValue API might be something you need to reach for anyway.
As a result, my proposal is to have the following APIs:
in ui.text:
fun CoreTextField(value: EditorValue, onValueChange: (EditorValue) -> Unit) (unchanged)
in ui.foundation:
fun TextField(EditorValue, (EditorValue) -> Unit) (unchanged)
fun TextField(value: String, onValueChange: (String) -> Unit, onSelectionChanged: (Selection) -> Unit)
in ui.material:
fun FilledTextField(EditorValue, (EditorValue) -> Unit)
fun FilledTextField(value: String, onValueChange: (String) -> Unit, onSelectionChanged: (Selection) -> Unit)