Fixed
Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 624335f1c93a6e185fc21c2796ffe2560ba4b886
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Apr 30 16:17:33 2020
Inline the -ktx setFragmentResultListener methods
This inlines the setFragmentResultListener method for the
FragmentResultOwner and Fragment kotlin extensions to prevent from
allocating multiple lambdas
Test: existing tests pass
Bug: 155323404
Change-Id: I4b161039169c89524d69689f931cc0ca50f81827
M fragment/fragment-ktx/api/1.3.0-alpha05.txt
M fragment/fragment-ktx/api/current.txt
M fragment/fragment-ktx/api/public_plus_experimental_1.3.0-alpha05.txt
M fragment/fragment-ktx/api/public_plus_experimental_current.txt
M fragment/fragment-ktx/api/restricted_1.3.0-alpha05.txt
M fragment/fragment-ktx/api/restricted_current.txt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/Fragment.kt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/FragmentResultOwner.kt
https://android-review.googlesource.com/1299618
Branch: androidx-master-dev
commit 624335f1c93a6e185fc21c2796ffe2560ba4b886
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Apr 30 16:17:33 2020
Inline the -ktx setFragmentResultListener methods
This inlines the setFragmentResultListener method for the
FragmentResultOwner and Fragment kotlin extensions to prevent from
allocating multiple lambdas
Test: existing tests pass
Bug: 155323404
Change-Id: I4b161039169c89524d69689f931cc0ca50f81827
M fragment/fragment-ktx/api/1.3.0-alpha05.txt
M fragment/fragment-ktx/api/current.txt
M fragment/fragment-ktx/api/public_plus_experimental_1.3.0-alpha05.txt
M fragment/fragment-ktx/api/public_plus_experimental_current.txt
M fragment/fragment-ktx/api/restricted_1.3.0-alpha05.txt
M fragment/fragment-ktx/api/restricted_current.txt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/Fragment.kt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/FragmentResultOwner.kt
jb...@google.com
This has been fixed internally and will be available in the Fragment 1.3.0-alpha05 release.
Description
Version used: 1.3.0-alpha04
Devices/Android versions reproduced on: any version
Since all the extension functions for Fragment result API are not "inline", calling setFragmentResultListener requires a double listener allocation: one for the Function2 passed to the extension function, and one for the actual FragmentResultListener that wraps Function2.
This applies for both Fragment.kt and FragmentResultOwner.kt files.
The fix is straightforward: mark the functions as "inline" and the listeners as "crossinline".
Now only the FragmentResultListener will be allocated.