Fixed
Status Update
Comments
lp...@google.com <lp...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5f47f78a5399f864438da0d78a60c6400deb837e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu May 21 14:45:05 2020
Adds state layer integration to RippleIndication and deprecates Modifier.ripple
RippleIndication now handles dragged state, and will be updated to support other states
such as focus in the future.
Migrates / suppresses remaining usages.
Bug: b/146345816
Bug: b/155375067
Test: updateApi, existing tests
Relnote: "Deprecates Modifier.ripple. Clickable now uses ripple as the default indication (if you have a MaterialTheme {} set in your application) so in most cases you can just use clickable and get ripple indication for free. If you need to customize the color / size / bounded parameter for the ripple, you can manually create a RippleIndication and pass it to clickable as the indication parameter."
Change-Id: I101cd0adac4e1f466f84a35c1b3f2db1e7a69472
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/PointerInputInteropComposeInAndroid.kt
M ui/ui-material/api/0.1.0-dev14.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev14.txt
M ui/ui-material/api/restricted_current.txt
D ui/ui-material/samples/src/main/java/androidx/ui/material/samples/RippleSamples.kt
D ui/ui-material/src/androidTest/java/androidx/ui/material/RippleTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleAnimation.kt
D ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleEffect.kt
D ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleEffectFactory.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleIndication.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleTheme.kt
M ui/ui-material/src/test/java/androidx/ui/material/ripple/RippleAnimationTest.kt
https://android-review.googlesource.com/1316554
Branch: androidx-master-dev
commit 5f47f78a5399f864438da0d78a60c6400deb837e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu May 21 14:45:05 2020
Adds state layer integration to RippleIndication and deprecates Modifier.ripple
RippleIndication now handles dragged state, and will be updated to support other states
such as focus in the future.
Migrates / suppresses remaining usages.
Bug:
Bug:
Test: updateApi, existing tests
Relnote: "Deprecates Modifier.ripple. Clickable now uses ripple as the default indication (if you have a MaterialTheme {} set in your application) so in most cases you can just use clickable and get ripple indication for free. If you need to customize the color / size / bounded parameter for the ripple, you can manually create a RippleIndication and pass it to clickable as the indication parameter."
Change-Id: I101cd0adac4e1f466f84a35c1b3f2db1e7a69472
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/PointerInputInteropComposeInAndroid.kt
M ui/ui-material/api/0.1.0-dev14.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev14.txt
M ui/ui-material/api/restricted_current.txt
D ui/ui-material/samples/src/main/java/androidx/ui/material/samples/RippleSamples.kt
D ui/ui-material/src/androidTest/java/androidx/ui/material/RippleTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/Slider.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleAnimation.kt
D ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleEffect.kt
D ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleEffectFactory.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleIndication.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/RippleTheme.kt
M ui/ui-material/src/test/java/androidx/ui/material/ripple/RippleAnimationTest.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1d2811868c5011e82000604f2ffeb9ab7501f845
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Jul 08 17:26:17 2020
Remove deprecated Modifier.ripple
Also removes workaround in Clickable to support the old Ripple implementation
Bug: b/154589321
Bug: b/155375067
Test: n/a
Relnote: "Removes previously deprecated Modifier.ripple. Clickable now uses ripple as the default indication (if you have a MaterialTheme {} set in your application) so in most cases you can just use clickable and get ripple indication for free. If you need to customize the color / size / bounded parameter for the ripple, you can manually create a RippleIndication and pass it to clickable as the indication parameter."
Change-Id: I663b2fcbdc3079343b54dcf713f5d467e39b87a5
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-material/api/0.1.0-dev15.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev15.txt
M ui/ui-material/api/restricted_current.txt
D ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
https://android-review.googlesource.com/1358543
Branch: androidx-master-dev
commit 1d2811868c5011e82000604f2ffeb9ab7501f845
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Jul 08 17:26:17 2020
Remove deprecated Modifier.ripple
Also removes workaround in Clickable to support the old Ripple implementation
Bug:
Bug:
Test: n/a
Relnote: "Removes previously deprecated Modifier.ripple. Clickable now uses ripple as the default indication (if you have a MaterialTheme {} set in your application) so in most cases you can just use clickable and get ripple indication for free. If you need to customize the color / size / bounded parameter for the ripple, you can manually create a RippleIndication and pass it to clickable as the indication parameter."
Change-Id: I663b2fcbdc3079343b54dcf713f5d467e39b87a5
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-material/api/0.1.0-dev15.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev15.txt
M ui/ui-material/api/restricted_current.txt
D ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
Description