Fixed
Status Update
No update yet.
Comments
ra...@google.com
ra...@google.com
Fixed in aosp/2133650.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 47782e507ed18b73c1453949544bb7075edfe6dd
Author: Alan Viverette <alanv@google.com>
Date: Tue Jun 21 16:27:55 2022
Clean up lint issues in arch core
Does not fix nullability for methods inheriting from JUnit TestWatcher,
which is not annotated.
Relnote: Updated nullability
Fixes: 236472329
Fixes: 236472101
Fixes: 236472102
Fixes: 236471987
Fixes: 236472078
Fixes: 236472176
Fixes: 236471905
Fixes: 236472103
Test: arch core test suite
Change-Id: I34b6b636572f1bce61d38af563b4a989aa108f82
M arch/core/core-testing/api/restricted_current.txt
M arch/core/core-runtime/api/restricted_current.txt
M arch/core/core-runtime/src/main/java/androidx/arch/core/executor/ArchTaskExecutor.java
M arch/core/core-common/src/main/java/androidx/arch/core/internal/SafeIterableMap.java
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/testing/CountingTaskExecutorRule.java
M arch/core/core-testing/api/public_plus_experimental_current.txt
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/JunitTaskExecutorRule.java
M arch/core/core-common/api/restricted_current.txt
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/testing/InstantTaskExecutorRule.java
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/TaskExecutorWithFakeMainThread.java
M arch/core/core-testing/api/current.txt
M arch/core/core-common/src/main/java/androidx/arch/core/internal/FastSafeIterableMap.java
M arch/core/core-runtime/src/main/java/androidx/arch/core/executor/DefaultTaskExecutor.java
https://android-review.googlesource.com/2133650
Branch: androidx-main
commit 47782e507ed18b73c1453949544bb7075edfe6dd
Author: Alan Viverette <alanv@google.com>
Date: Tue Jun 21 16:27:55 2022
Clean up lint issues in arch core
Does not fix nullability for methods inheriting from JUnit TestWatcher,
which is not annotated.
Relnote: Updated nullability
Fixes: 236472329
Fixes: 236472101
Fixes: 236472102
Fixes: 236471987
Fixes: 236472078
Fixes: 236472176
Fixes: 236471905
Fixes: 236472103
Test: arch core test suite
Change-Id: I34b6b636572f1bce61d38af563b4a989aa108f82
M arch/core/core-testing/api/restricted_current.txt
M arch/core/core-runtime/api/restricted_current.txt
M arch/core/core-runtime/src/main/java/androidx/arch/core/executor/ArchTaskExecutor.java
M arch/core/core-common/src/main/java/androidx/arch/core/internal/SafeIterableMap.java
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/testing/CountingTaskExecutorRule.java
M arch/core/core-testing/api/public_plus_experimental_current.txt
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/JunitTaskExecutorRule.java
M arch/core/core-common/api/restricted_current.txt
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/testing/InstantTaskExecutorRule.java
M arch/core/core-testing/src/main/java/androidx/arch/core/executor/TaskExecutorWithFakeMainThread.java
M arch/core/core-testing/api/current.txt
M arch/core/core-common/src/main/java/androidx/arch/core/internal/FastSafeIterableMap.java
M arch/core/core-runtime/src/main/java/androidx/arch/core/executor/DefaultTaskExecutor.java
Description
Context
Component used: work-runtime
Version used: 2.4.0 Alpha 3
Devices/Android versions reproduced on: Android 7
Description
When running a Worker with constraints that calls setForegroundAsync() on Android 7 (and potentially earlier) the foreground service is started but not stopped after the worker has completed execution.
On Android 8, 9, and 10, the foreground service is stopped as expected when the worker completes and the notification is removed.
The bug only occurs for workers that have constraints. If no constraints are set, the behavior on Android 7 is correct as well.
Sample project
Github projecthttps://github.com/otbinary/workmanager-foreground-worker contains a small sample app.
A foreground worker with a constraint (
setRequiresBatteryNotLow) that sleeps for five seconds can be started by a broadcast intent:adb shell am broadcast -n com.github.otbinary.fgworker/.StartSleepingWorkerBroadcastReceiverObservations
On Android 7,
WorkerWrapper.resolve()is called only for aConstraintTrackingWorkerinstance that is wrapped around the actualSleepingWorkerinstance.ConstraintTrackingWorker.isRunInForeground()isfalse.resolve()therefore does not callmForegroundProcessor.stopForeground().On Android 8+,
resolve()is called for the actualSleepingWorkerinstance whoseisRunInForeground()returnstrue.resolve()callsmForegroundProcessor.stopForeground().