Fixed
Status Update
Comments
cl...@google.com <cl...@google.com>
lp...@google.com <lp...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug: b/161809385
Bug: b/161807956
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
ma...@google.com <ma...@google.com> #3
Yep, we're missing it as we didn't have it at that time! Will add
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit f01d78990b9f0e8a41a06a7e41b76c37fbad601f
Author: Matvei Malkov <malkov@google.com>
Date: Fri Jun 05 14:52:06 2020
Switch rework 3
This CL reworks switch internals and API, to make it more customizable and support new features
In particular:
* Switch supports disabled state properly
* Proper indication when clicking or dragging
* dynamic elevation when pressed or dragged
Relnote: Switch now appears in a disabled state when `enabled` is set to false
Fixes: 155941869
Fixes: 144797838
Fixes: 158808522
Fixes: 159069619
Fixes: 159331694
Test: screenshot tests has been added
Change-Id: If46244d35274f24d3713422c8d28b5b870fb8c84
A ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchScreenshotTest.kt
A ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchTest.kt
D ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
https://android-review.googlesource.com/1324521
Branch: androidx-master-dev
commit f01d78990b9f0e8a41a06a7e41b76c37fbad601f
Author: Matvei Malkov <malkov@google.com>
Date: Fri Jun 05 14:52:06 2020
Switch rework 3
This CL reworks switch internals and API, to make it more customizable and support new features
In particular:
* Switch supports disabled state properly
* Proper indication when clicking or dragging
* dynamic elevation when pressed or dragged
Relnote: Switch now appears in a disabled state when `enabled` is set to false
Fixes: 155941869
Fixes: 144797838
Fixes: 158808522
Fixes: 159069619
Fixes: 159331694
Test: screenshot tests has been added
Change-Id: If46244d35274f24d3713422c8d28b5b870fb8c84
A ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchScreenshotTest.kt
A ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchTest.kt
D ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
Description
Android Studio Build: 4.1 Canary 8
Version of Gradle Plugin: 4.1.0-alpha08
Version of Gradle: 6.3
Version of Java: 1.8
Compose Version: 0.1.0-dev10
When checked,
Switch
thumbs show the color palette secondary color, as expected. However, when unchecked, the thumbs completely blend into the surface they are on top of. This occurs on both light and dark theme palettes (screenshots attached).