Fixed
Status Update
Comments
cl...@google.com <cl...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug: b/161809385
Bug: b/161807956
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4de954e69fa4af459c3c23e0b1e761dae9dafeee
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Mon Jun 01 14:25:49 2020
Fix Crossfade doesn't work with null initial value
Relnote: Crossfade can now work with null as initial value
Fixes: 155947711
Test: new test
Change-Id: Iad6a45933469434110ffdf5a55dd2e8eda37035a
M ui/ui-animation/src/androidTest/java/androidx/ui/animation/CrossfadeTest.kt
M ui/ui-animation/src/main/java/androidx/ui/animation/Crossfade.kt
https://android-review.googlesource.com/1321041
Branch: androidx-master-dev
commit 4de954e69fa4af459c3c23e0b1e761dae9dafeee
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Mon Jun 01 14:25:49 2020
Fix Crossfade doesn't work with null initial value
Relnote: Crossfade can now work with null as initial value
Fixes: 155947711
Test: new test
Change-Id: Iad6a45933469434110ffdf5a55dd2e8eda37035a
M ui/ui-animation/src/androidTest/java/androidx/ui/animation/CrossfadeTest.kt
M ui/ui-animation/src/main/java/androidx/ui/animation/Crossfade.kt
Description
Android Studio Build: Android Studio 4.1 Canary 8
Version of Gradle Plugin: 4.1.0-alpha08
Version of Gradle: 6.3
Version of Java: Java 11
OS: macOS 10.15.4
Steps to Reproduce:
Expected: A yellow screen
Actual: A white screen
Additional notes:
You can fix the issue by passing
1
as the current state forCrossfade
Description:
If you pass
null
as the initial state toCrossfade
it doesn't compose properly and a white screen is shown.The reason is the statement
if (current != state.current)
which fails sincestate.current
default tonull
.Crossfade needs to use a sentinel value instead of
null
as it's internal default value or make the type parameterT
non null to prevent this issue.