Support sans-serif-medium on older devices [156048036]

Fixed

Bug

Status Update

No update yet.

Description

mo...@gmail.com

created issue #1

May 8, 2020 06:47AM

Medium font weight is fairly common in default Material UI Design.

Currently the GenericFontFamily and DefaultFontFamily will not resolve medium font weight on SDK version < 28, because it use new API on API 28, but one can use old API instead because the typeface is present as sans-serif-medium

(I have locally some changes implement this. Can I make a PR?

Comments

si...@google.com <si...@google.com> #2May 25, 2020 07:27PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

si...@google.com <si...@google.com> #3May 25, 2020 07:28PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

si...@google.com <si...@google.com> May 26, 2020 01:26AM

Reassigned to mo...@gmail.com.

mo...@gmail.com <mo...@gmail.com> #4May 26, 2020 05:41AM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

si...@google.com <si...@google.com> #5Nov 17, 2021 02:03AM

deleted

si...@google.com <si...@google.com> Nov 17, 2021 02:28AM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #6Mar 22, 2022 12:02AM

Marked as fixed.

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

si...@google.com <si...@google.com> #7Mar 22, 2022 05:06AM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

se...@google.com <se...@google.com> #8Mar 22, 2022 06:19PM

Status: Assigned (reopened)

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

ap...@google.com <ap...@google.com> #9Apr 13, 2022 03:16AM