Support sans-serif-medium on older devices [156048036]

Fixed

Bug

Status Update

No update yet.

Description

mo...@gmail.com

created issue #1

May 8, 2020 06:47AM

Medium font weight is fairly common in default Material UI Design.

Currently the GenericFontFamily and DefaultFontFamily will not resolve medium font weight on SDK version < 28, because it use new API on API 28, but one can use old API instead because the typeface is present as sans-serif-medium

(I have locally some changes implement this. Can I make a PR?

Comments

si...@google.com <si...@google.com> #2May 25, 2020 07:27PM

Hi molikto@

Can you please share a code snippet for what exactly is not working?

sans-serif-medium is an alias to san-serif with font weight 500 in framework link

si...@google.com <si...@google.com> #3May 25, 2020 07:28PM

Also, of course PRs (or CLS on AOSP) is always welcome.

si...@google.com <si...@google.com> May 26, 2020 01:26AM

Reassigned to mo...@gmail.com.

mo...@gmail.com <mo...@gmail.com> #4May 26, 2020 05:41AM

Hello.

I think it is more clear with the changes I made: https://android-review.googlesource.com/c/platform/frameworks/support/+/1316922

The code get run for API < 28 basically ends up as Typeface.defaultFromStyle(NORMAL) for medium font weight.

si...@google.com <si...@google.com> #5Nov 17, 2021 02:03AM

sans-serif-medium was mentioned in the dupped ticket

si...@google.com <si...@google.com> Nov 17, 2021 02:28AM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #6Mar 22, 2022 12:02AM

Marked as fixed.

This is replaced by font fallback chains using FontListFontFamily.

The desired result may now be produced via:

FontListFontFamily(listOf( Font(AndroidFontFamilyName("sans-serif-medium")) /* potentially API-level guard this if desired */ ))

API may change name prior to merge, follow https://android-review.googlesource.com/c/platform/frameworks/support/+/2034291

si...@google.com <si...@google.com> #7Mar 22, 2022 05:06AM

for reference go/compose-sans-serif-condensed

se...@google.com <se...@google.com> #8Mar 22, 2022 06:19PM

Status: Assigned (reopened)

Re-opening this ticket to evaluate the declaration of FontFamily.SansSerif

ap...@google.com <ap...@google.com> #9Apr 13, 2022 03:16AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 5b592cf812bbe2880c42520791d8659d26e1307c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Mar 30 16:39:47 2022

Use <API28 fallback font names for system fonts

This loads fallback font names for system fonts

sans-serif-thin, -light -medium, -black

Fixes a user-visible bug where font weights available on the system were
not usable prior to API 28.

This will also attempt the fallback for other font families, in case a
device contains the font for other weights.

Fixes:

b/156048036

Fixes:

b/226441992

Test: ./gradlew :compose:ui:ui-text:cAT
Test: New demo with all system fonts @ all weights visible
Relnote: "Display all available weights for systems fonts on Android
when using FontFamily.SansSerif. This will use fallback font names like
sans-serif-medium internally on API 21-28. This is a behavior change as
previously only weights 400 and 700 were supported on API 21-28."

Change-Id: I380fecb5ba839eecbf0b08acbca6247082b605d7

A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformTypefaces.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontUtils.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/SystemFontFamilyDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformFontFamilyTypefaceAdapter.android.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/PlatformTypefacesTest.kt
M compose/ui/ui-text/api/current.txt

https://android-review.googlesource.com/2050558