Support sans-serif-medium on older devices [156048036]

Fixed

Bug

Status Update

No update yet.

Description

mo...@gmail.com

created issue #1

May 8, 2020 06:47AM

Medium font weight is fairly common in default Material UI Design.

Currently the GenericFontFamily and DefaultFontFamily will not resolve medium font weight on SDK version < 28, because it use new API on API 28, but one can use old API instead because the typeface is present as sans-serif-medium

(I have locally some changes implement this. Can I make a PR?

Comments

si...@google.com <si...@google.com> #2May 25, 2020 07:27PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

si...@google.com <si...@google.com> #3May 25, 2020 07:28PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

si...@google.com <si...@google.com> May 26, 2020 01:26AM

Reassigned to mo...@gmail.com.

mo...@gmail.com <mo...@gmail.com> #4May 26, 2020 05:41AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

si...@google.com <si...@google.com> #5Nov 17, 2021 02:03AM

sans-serif-medium was mentioned in the dupped ticket

si...@google.com <si...@google.com> Nov 17, 2021 02:28AM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> #6Mar 22, 2022 12:02AM

Marked as fixed.

This is replaced by font fallback chains using FontListFontFamily.

The desired result may now be produced via:

FontListFontFamily(listOf( Font(AndroidFontFamilyName("sans-serif-medium")) /* potentially API-level guard this if desired */ ))

API may change name prior to merge, follow https://android-review.googlesource.com/c/platform/frameworks/support/+/2034291

si...@google.com <si...@google.com> #7Mar 22, 2022 05:06AM

for reference go/compose-sans-serif-condensed

se...@google.com <se...@google.com> #8Mar 22, 2022 06:19PM

Status: Assigned (reopened)

Re-opening this ticket to evaluate the declaration of FontFamily.SansSerif

ap...@google.com <ap...@google.com> #9Apr 13, 2022 03:16AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 5b592cf812bbe2880c42520791d8659d26e1307c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Mar 30 16:39:47 2022

Use <API28 fallback font names for system fonts

This loads fallback font names for system fonts

sans-serif-thin, -light -medium, -black

Fixes a user-visible bug where font weights available on the system were
not usable prior to API 28.

This will also attempt the fallback for other font families, in case a
device contains the font for other weights.

Fixes:

b/156048036

Fixes:

b/226441992

Test: ./gradlew :compose:ui:ui-text:cAT
Test: New demo with all system fonts @ all weights visible
Relnote: "Display all available weights for systems fonts on Android
when using FontFamily.SansSerif. This will use fallback font names like
sans-serif-medium internally on API 21-28. This is a behavior change as
previously only weights 400 and 700 were supported on API 21-28."

Change-Id: I380fecb5ba839eecbf0b08acbca6247082b605d7

A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformTypefaces.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontUtils.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/SystemFontFamilyDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformFontFamilyTypefaceAdapter.android.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/PlatformTypefacesTest.kt
M compose/ui/ui-text/api/current.txt

https://android-review.googlesource.com/2050558