CameraView crash when "back" pressed while capturing image [156196993]

Fixed

Bug

Status Update

No update yet.

Description

si...@gmail.com

created issue #1

May 11, 2020 11:27AM

CAMERAX VERSION: 1.0.0-beta03

CAMERAVIEW VERSION: 1.0.0-alpha10

ANDROID OS BUILD NUMBER: QP1A.191005.007.A3

DEVICE NAME: Pixel XL

DESCRIPTION: CameraView is bound to viewLifecycleOwner and is used to take pictures and save them to file using
takePicture(fileToSaveImageTo, executor, captureCallback) method, where executor is retrieved using ContextCompat.getMainExecutor(requireContext()) method. If I click "back" while takePicture is still in progress

STEPS TO REPRODUCE:
1. Call takePicture(@NonNull File file, @NonNull Executor executor,
@NonNull OnImageSavedCallback callback)
2. Click "back" while picture is being taken

REPRODUCIBILITY: 3 of 5

ADDITIONAL INFORMATION: Stack trace
E/AndroidRuntime: FATAL EXCEPTION: CameraX-camerax_io_0
Process: com.lasership.eliv2, PID: 26217
java.lang.IllegalStateException: Image is already closed
at android.media.Image.throwISEIfImageIsInvalid(Image.java:72)
at android.media.ImageReader$SurfaceImage.getFormat(ImageReader.java:819)
at androidx.camera.core.AndroidImageProxy.getFormat(AndroidImageProxy.java:78)
at androidx.camera.core.ForwardingImageProxy.getFormat(ForwardingImageProxy.java:75)
at androidx.camera.core.ForwardingImageProxy.getFormat(ForwardingImageProxy.java:75)
at androidx.camera.core.ForwardingImageProxy.getFormat(ForwardingImageProxy.java:75)
at androidx.camera.core.ImageSaver.run(ImageSaver.java:105)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:919)

Sometimes everuthing's handled fine with just a cancellation exception in logcat:
java.lang.RuntimeException: androidx.camera.core.CameraControl$OperationCanceledException: Cancelled by cancelFocusAndMetering()

Comments

fu...@google.com <fu...@google.com> #2May 11, 2020 09:57PM

After some googling I found

https://github.com/android/camera-samples/blob/master/CameraXBasic/app/src/main/java/com/android/example/cameraxbasic/utils/AutoFitPreviewBuilder.kt which does what I want. Would it be possible to fold this into the main library or at least make it configurable without the need for that class?

fu...@google.com <fu...@google.com> May 14, 2020 08:44PM

Reassigned to bu...@google.com.

bu...@google.com <bu...@google.com> #3May 14, 2020 08:50PM

Accepted by bu...@google.com.

Hi Charcoal,

Are we getting a crop mode here? Thanks!

si...@gmail.com <si...@gmail.com> #4Jun 16, 2020 08:29AM

Hello,
Thanks for raising this up. May we know did you set aspect ratio or resolution for Preview use case? And could you also attach the captured image file?

bu...@google.com <bu...@google.com> Jul 1, 2020 12:52AM

Assigned to ca...@google.com.

fu...@google.com <fu...@google.com> #5Jul 16, 2020 09:21PM

The captured image file is part of the image file that I've already attached (the right part).

I did not set anything on the Preview use case other than the lens facing.

```
val cameraPreview = Preview(Builder()
.setLensFacing(CameraX.LensFacing.BACK)
.build())

cameraPreview.setOnPreviewOutputUpdateListener {
// Every time the viewfinder is updated, recompute the layout. By removing and re-adding it.
val parent = parent as ViewGroup
parent.removeView(this)
parent.addView(this, 0)

surfaceTexture = it.surfaceTexture
updateTransform()
}

CameraX.bindToLifecycle(lifecycleOwner, cameraPreview, *useCase)
```

fu...@google.com <fu...@google.com> #6Jul 16, 2020 09:21PM

Reassigned to bu...@google.com.

Would you also set the same TargetRotation to Preview at onOrientationChanged? Let me know if it works.

bu...@google.com <bu...@google.com> #7Jul 16, 2020 09:21PM

Accepted by bu...@google.com.

Hi There,

It's been just over a month and we are clearing out issues without response. If you have any feedback please feel free to reopen or file another issue. Thanks!

bu...@google.com <bu...@google.com> Jul 30, 2020 09:24PM

Assigned to ca...@google.com.

[Deleted User] <[Deleted User]> #8Sep 4, 2020 06:51AM

This should be caused by same root cause of

https://b.corp.google.com/issues/148763432.
There is default aspect ratio custom set to ImageCapture use case but it is not updated to match the new target rotation value.

we...@google.com <we...@google.com> #9Sep 9, 2020 08:52AM

@sidevoice@gmail.com, @debdeep.ganguly@paytm.com Thanks your info and want to double confirm comment #1, comment #4, comment #8.

The repro steps is the same in comment #1, but only fail on devices mentioned on comment #8, correct? Still have failure on devices in comment #4?

Will try to use CameraXBasic sample to verify on these devices again.

si...@gmail.com <si...@gmail.com> #10Sep 9, 2020 10:56AM

Hi. Unfortunately cannot confirm/deny if the issue is reproducible on the devices from comment #4, as we haven't been able to receive reports on the newer library versions for those devices yet (will probably happen towards the end of the month). However the steps from both comment #1 and comment #4 are no longer reproducible on the device the issue was reproduced initially (Pixel XL Android 10).

we...@google.com <we...@google.com> #11Sep 10, 2020 03:04AM

Hi,
Thanks the quick update from @sidevoice@gmail.com. Let's keep monitor and wait for your update.

Will focus on comment #8 devices and try to repro.

er...@google.com <er...@google.com> #12Sep 10, 2020 05:49PM

Reassigned to bu...@google.com.

Bugjuggler: wait next month

bu...@google.com <bu...@google.com> #13Sep 10, 2020 05:49PM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait until 2020-10-01 00:00 -0700 PDT and then assign the bug to camerax-bugs@google.com.

bu...@google.com <bu...@google.com> Oct 1, 2020 07:21AM

Assigned to ca...@google.com.

wu...@google.com <wu...@google.com> Oct 13, 2020 01:55AM

Reassigned to xi...@google.com.

er...@google.com <er...@google.com> #14Oct 13, 2020 01:57AM

Hey Xi,

Did you want to do anything else here?

xi...@google.com <xi...@google.com> #15Oct 13, 2020 04:08PM

Looks like this needs to be handled in core. I can take a look.

xi...@google.com <xi...@google.com> #16Nov 3, 2020 10:30PM

Marked as fixed.

This is no longer reproducible. Probably fixed in a previous version.

Issue 156196993

Description

Issue summary

Comments

fu...@google.com <fu...@google.com> #2May 11, 2020 09:57PM

fu...@google.com <fu...@google.com> May 14, 2020 08:44PM

bu...@google.com <bu...@google.com> #3May 14, 2020 08:50PM

si...@gmail.com <si...@gmail.com> #4Jun 16, 2020 08:29AM

bu...@google.com <bu...@google.com> Jul 1, 2020 12:52AM

fu...@google.com <fu...@google.com> #5Jul 16, 2020 09:21PM

fu...@google.com <fu...@google.com> #6Jul 16, 2020 09:21PM

bu...@google.com <bu...@google.com> #7Jul 16, 2020 09:21PM

bu...@google.com <bu...@google.com> Jul 30, 2020 09:24PM

[Deleted User] <[Deleted User]> #8Sep 4, 2020 06:51AM

we...@google.com <we...@google.com> #9Sep 9, 2020 08:52AM

si...@gmail.com <si...@gmail.com> #10Sep 9, 2020 10:56AM

we...@google.com <we...@google.com> #11Sep 10, 2020 03:04AM

er...@google.com <er...@google.com> #12Sep 10, 2020 05:49PM

bu...@google.com <bu...@google.com> #13Sep 10, 2020 05:49PM

bu...@google.com <bu...@google.com> Oct 1, 2020 07:21AM

wu...@google.com <wu...@google.com> Oct 13, 2020 01:55AM

er...@google.com <er...@google.com> #14Oct 13, 2020 01:57AM

xi...@google.com <xi...@google.com> #15Oct 13, 2020 04:08PM

xi...@google.com <xi...@google.com> #16Nov 3, 2020 10:30PM

Add comment

Issue metadata