ConcurrentModificationException in DelegatingWorkerFactory class [156289105]

Fixed

Bug

Status Update

No update yet.

Description

ul...@gmail.com

created issue #1

May 12, 2020 10:26AM

Component used: WorkManager Version used: 2.2.0 Devices/Android versions reproduced on: All versions

Stacktrace:

java.util.ConcurrentModificationException: null
    at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:966)
    at java.util.LinkedList$ListItr.next(LinkedList.java:888)
    at androidx.work.DelegatingWorkerFactory.createWorker(DelegatingWorkerFactory.java:66)
    at androidx.work.WorkerFactory.createWorkerWithDefaultFallback(WorkerFactory.java:81)
    at androidx.work.impl.WorkerWrapper.runWorker(WorkerWrapper.java:228)
    at androidx.work.impl.WorkerWrapper.run(WorkerWrapper.java:127)
    at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
    at java.lang.Thread.run(Thread.java:764)

It seems that method addFactory of DelegatingWorkerFactory class tries to modify mFactories list while another thread is iterating over it.

Comments

ul...@gmail.com <ul...@gmail.com> #2May 12, 2020 10:28AM

Sorry for bad formatting. Probably markdown parser doesn't recognize new lines.

ra...@google.com <ra...@google.com> #3May 12, 2020 04:30PM

Are you modifying the list of factories after WorkManager has been initialized ?

ra...@google.com <ra...@google.com> #4May 12, 2020 04:31PM

Also, can you please try using the latest stable version of WorkManager.

ra...@google.com <ra...@google.com> May 12, 2020 06:07PM

Assigned to ra...@google.com.

ap...@google.com <ap...@google.com> #5May 12, 2020 11:37PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c1049b718d42148c90fa17b8c6ab32867cbeeb5a
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue May 12 15:30:11 2020

Make `DelegatingWorkerFactory` thread safe.

* This makes it easier to add factories dynamically. Might be useful
in the context of dynamic feature modules.

Test: Existing unit tests pass.
Fixes:

b/156289105

Change-Id: Id8e656b6f96f5a1b336e50b2f5b0a5c914098063

M work/workmanager/src/main/java/androidx/work/DelegatingWorkerFactory.java

https://android-review.googlesource.com/1309745

ul...@gmail.com <ul...@gmail.com> #6May 13, 2020 08:59AM

Thanks!

Issue 156289105