ConcurrentModificationException in DelegatingWorkerFactory class [156289105]

Fixed

Bug

Status Update

No update yet.

Description

ul...@gmail.com

created issue #1

May 12, 2020 10:26AM

Component used: WorkManager Version used: 2.2.0 Devices/Android versions reproduced on: All versions

Stacktrace:

java.util.ConcurrentModificationException: null
    at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:966)
    at java.util.LinkedList$ListItr.next(LinkedList.java:888)
    at androidx.work.DelegatingWorkerFactory.createWorker(DelegatingWorkerFactory.java:66)
    at androidx.work.WorkerFactory.createWorkerWithDefaultFallback(WorkerFactory.java:81)
    at androidx.work.impl.WorkerWrapper.runWorker(WorkerWrapper.java:228)
    at androidx.work.impl.WorkerWrapper.run(WorkerWrapper.java:127)
    at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
    at java.lang.Thread.run(Thread.java:764)

It seems that method addFactory of DelegatingWorkerFactory class tries to modify mFactories list while another thread is iterating over it.

Comments

ul...@gmail.com <ul...@gmail.com> #2May 12, 2020 10:28AM

Since this is happening in Tink, rather than in the AndroidX library, it would be best to open an issue with that project, as there isn't an easy way for us to fix this.

ra...@google.com <ra...@google.com> #3May 12, 2020 04:30PM

@2 I don't know what "Tink" is, but here, created:

https://github.com/google/tink/issues/534

Would this mean that this bug report should be written there as well:

https://issuetracker.google.com/issues/176215143
?

ra...@google.com <ra...@google.com> #4May 12, 2020 04:31PM

Tink is the library that does the heavy lifting in Jetpack Security.

And yes, potentially raising that issue with the Tink team directly could help.

ra...@google.com <ra...@google.com> May 12, 2020 06:07PM

Assigned to ra...@google.com.

ap...@google.com <ap...@google.com> #5May 12, 2020 11:37PM

Marked as fixed.

@4 Well why didn't Google offer it there? Crashes are far more important than warning logs...
Here, created it there too:

https://github.com/google/tink/issues/535

ul...@gmail.com <ul...@gmail.com> #6May 13, 2020 08:59AM

Anyone here solved the issue? I have implemented the jetpack security and got the same crashes.

Issue 156289105