ConcurrentModificationException in DelegatingWorkerFactory class [156289105]

Fixed

Bug

Status Update

No update yet.

Description

ul...@gmail.com

created issue #1

May 12, 2020 10:26AM

Component used: WorkManager Version used: 2.2.0 Devices/Android versions reproduced on: All versions

Stacktrace:

java.util.ConcurrentModificationException: null
    at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:966)
    at java.util.LinkedList$ListItr.next(LinkedList.java:888)
    at androidx.work.DelegatingWorkerFactory.createWorker(DelegatingWorkerFactory.java:66)
    at androidx.work.WorkerFactory.createWorkerWithDefaultFallback(WorkerFactory.java:81)
    at androidx.work.impl.WorkerWrapper.runWorker(WorkerWrapper.java:228)
    at androidx.work.impl.WorkerWrapper.run(WorkerWrapper.java:127)
    at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
    at java.lang.Thread.run(Thread.java:764)

It seems that method addFactory of DelegatingWorkerFactory class tries to modify mFactories list while another thread is iterating over it.

Comments

ul...@gmail.com <ul...@gmail.com> #2May 12, 2020 10:28AM

https://android-review.googlesource.com/c/platform/frameworks/support/+/1092870

ra...@google.com <ra...@google.com> #3May 12, 2020 04:30PM

Thank you for the quick fix.
Is there an ETA for the next release?

ra...@google.com <ra...@google.com> #4May 12, 2020 04:31PM

2.2.0-rc01 should be out this week.

ra...@google.com <ra...@google.com> May 12, 2020 06:07PM

Assigned to ra...@google.com.

ap...@google.com <ap...@google.com> #5May 12, 2020 11:37PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a1957df3709a06f4e6482fb0e4d39ded4f230a70
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Jul 29 09:48:05 2019

Workaround NPE in PersistableBundle.getExtras().

Test: Existing unit tests pass. Ran integration test app.
Fixes:

b/138441699

Change-Id: I0b48e0009a7d83c343a3d26112b94c057470c281

M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/1092870

https://goto.google.com/android-sha1/a1957df3709a06f4e6482fb0e4d39ded4f230a70

ul...@gmail.com <ul...@gmail.com> #6May 13, 2020 08:59AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6206758647365632/#/cherrypickHistory/all)
Created: 2019-07-29 19:41:55.445144+00:00
Changes: aosp/1092870

Issue 156289105