Foreground RxJava work is never cancelled [156310133]

Fixed

Bug

Status Update

No update yet.

Description

ar...@gmail.com

created issue #1

May 12, 2020 06:55AM

WorkManager versions: 2.3.4, 2.4.0-alpha03
Android version: 10
Device: emulator API level 29, x86

Put the following code in the Application subclass and call the scheduleForegroundWork method in the onCreate one.

Disable Wi-Fi.
Run the application.
Enable Wi-Fi.
Wait 5 seconds or so.
Disable Wi-Fi.
Results:
- Actual: work is not cancelled, the Single keeps working, the notification remains in place.
- Expected: work is cancelled, the Single is disposed, the notification is hidden.

private fun scheduleForegroundWork() {
    val workConstraints = Constraints.Builder()
        .setRequiredNetworkType(NetworkType.UNMETERED)
        .build()

    val workRequest = OneTimeWorkRequest.Builder(ForegroundWorker::class.java)
        .setConstraints(workConstraints)
        .build()

    WorkManager
        .getInstance(this)
        .enqueueUniqueWork("foreground-work", ExistingWorkPolicy.REPLACE, workRequest)
}

class ForegroundWorker(private val context: Context, parameters: WorkerParameters) : RxWorker(context, parameters) {

    companion object {
        private const val NOTIFICATION_CHANNEL_ID = "foreground-work"
    }

    override fun createWork() = Single
        .fromCallable {
            createNotificationChannel()

            setForegroundAsync(ForegroundInfo(42, createNotification())).get().toOptional()
        }
        .flatMapObservable {
            Observable
                .interval(0, 1, TimeUnit.SECONDS)
                .switchMap {
                    println("Worker interval $it")
         
                    if (it > 60) {
                        Observable.just(Unit)
                    } else {
                        Observable.never()
                    }
                }
        }
        .firstOrError()
        .map { Result.success() }

    private fun createNotificationChannel() {
        val channel = NotificationChannel(
            NOTIFICATION_CHANNEL_ID,
            "Foreground work",
            NotificationManager.IMPORTANCE_LOW
        )

        context.getSystemService<NotificationManager>()?.createNotificationChannel(channel)
    }

    private fun createNotification() = Notification.Builder(context, NOTIFICATION_CHANNEL_ID)
        .setSmallIcon(R.drawable.ic_notification)
        .setContentText("Hello there from the foreground work")
        .build()
}

Debug logs (2.4.0-alpha03):

// Open the application

WM-PackageManagerHelper: androidx.work.impl.background.systemjob.SystemJobService enabled
WM-Schedulers: Created SystemJobScheduler and enabled SystemJobService
WM-ForceStopRunnable: Performing cleanup operations.
WM-ForceStopRunnable: Application was force-stopped, rescheduling.
WM-PackageManagerHelper: androidx.work.impl.background.systemalarm.RescheduleReceiver enabled
WM-SystemJobScheduler: Scheduling work ID 8f1237eb-ea6c-415c-a512-c431c6ee985c Job ID 0
WM-GreedyScheduler: Starting tracking for [8f1237eb-ea6c-415c-a512-c431c6ee985c]
WM-ConstraintTracker: NetworkStateTracker: initial state = [ Connected=false Validated=false Metered=true NotRoaming=false ]
WM-NetworkStateTracker: Registering network callback
WM-GreedyScheduler: Constraints not met: Cancelling work ID 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-Processor: Processor stopping background work 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-Processor: WorkerWrapper could not be found for 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-StopWorkRunnable: StopWorkRunnable for 8f1237eb-ea6c-415c-a512-c431c6ee985c; Processor.stopWork = false

// Enable Wi-Fi

WM-NetworkStateTracker: Network capabilities changed: [ Transports: WIFI Capabilities: NOT_METERED&INTERNET&NOT_RESTRICTED&TRUSTED&NOT_VPN&NOT_ROAMING&FOREGROUND&NOT_CONGESTED&NOT_SUSPENDED LinkUpBandwidth>=1048576Kbps LinkDnBandwidth>=1048576Kbps SignalStrength: -30]
WM-WorkConstraintsTrack: Constraints met for 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-GreedyScheduler: Constraints met: Scheduling work ID 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-Processor: Processor: processing 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-WorkerWrapper: Starting work for PACKAGE.Application$ForegroundWorker
WM-Processor: Moving WorkSpec (8f1237eb-ea6c-415c-a512-c431c6ee985c) to the foreground
WM-SystemFgDispatcher: Started foreground service Intent { act=ACTION_START_FOREGROUND cmp=PACKAGE/androidx.work.impl.foreground.SystemForegroundService (has extras) }
WM-SystemFgDispatcher: Notifying with (id: 42, workSpecId: 8f1237eb-ea6c-415c-a512-c431c6ee985c, notificationType: 0)
WM-SystemFgDispatcher: Notifying with (id: 42, workSpecId: 8f1237eb-ea6c-415c-a512-c431c6ee985c, notificationType: 0)
WM-NetworkStateTracker: Network capabilities changed: [ Transports: WIFI Capabilities: NOT_METERED&INTERNET&NOT_RESTRICTED&TRUSTED&NOT_VPN&VALIDATED&NOT_ROAMING&FOREGROUND&NOT_CONGESTED&NOT_SUSPENDED LinkUpBandwidth>=1048576Kbps LinkDnBandwidth>=1048576Kbps SignalStrength: -30]
WM-WorkConstraintsTrack: Constraints met for 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-SystemJobService: onStartJob for 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-Processor: Processor: processing 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-WorkConstraintsTrack: Constraints met for 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-GreedyScheduler: Constraints met: Scheduling work ID 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-WorkConstraintsTrack: Constraints met for 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-WorkerWrapper: Status for 8f1237eb-ea6c-415c-a512-c431c6ee985c is RUNNING;not doing any work and rescheduling for later execution
WM-WorkerWrapper: PACKAGE.Application$ForegroundWorker is not in ENQUEUED state. Nothing more to do.
WM-Processor: Processor 8f1237eb-ea6c-415c-a512-c431c6ee985c executed; reschedule = true
WM-GreedyScheduler: Stopping tracking for 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-NetworkStateTracker: Unregistering network callback
WM-SystemJobService: 8f1237eb-ea6c-415c-a512-c431c6ee985c executed on JobScheduler
WM-Processor: Processor: processing 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-WorkerWrapper: Status for 8f1237eb-ea6c-415c-a512-c431c6ee985c is RUNNING;not doing any work and rescheduling for later execution
WM-Processor: Processor 8f1237eb-ea6c-415c-a512-c431c6ee985c executed; reschedule = true
WM-WorkerWrapper: PACKAGE.Application$ForegroundWorker is not in ENQUEUED state. Nothing more to do.

// Disable Wi-Fi (nothing is printed)

// Pass 60 seconds for Single to complete

WM-WorkerWrapper: PACKAGE.Application$ForegroundWorker returned a Success {mOutputData=Data {}} result.
WM-WorkerWrapper: Worker result SUCCESS for Work [ id=8f1237eb-ea6c-415c-a512-c431c6ee985c, tags={ PACKAGE.Application$ForegroundWorker } ]
WM-PackageManagerHelper: androidx.work.impl.background.systemalarm.RescheduleReceiver disabled
WM-Processor: No more foreground work. Stopping SystemForegroundService
WM-SystemFgDispatcher: Stopping foreground service
WM-SystemFgService: All commands completed.
WM-Processor: Processor 8f1237eb-ea6c-415c-a512-c431c6ee985c executed; reschedule = false
WM-GreedyScheduler: Cancelling work ID 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-Processor: Processor stopping background work 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-Processor: WorkerWrapper could not be found for 8f1237eb-ea6c-415c-a512-c431c6ee985c
WM-StopWorkRunnable: StopWorkRunnable for 8f1237eb-ea6c-415c-a512-c431c6ee985c; Processor.stopWork = false

Comments

ra...@google.com <ra...@google.com> #2May 12, 2020 04:34PM

Hi there, thank you for the question. We will add it to the work pipeline and get back to you.

ar...@gmail.com <ar...@gmail.com> #3May 12, 2020 05:08PM

I think you can set the zoom ratio right after cameraController.bindToLifecycle(this)

This should achieve what you want.

work-manager-observable.zip

251 KB

Download

ra...@google.com <ra...@google.com> #4May 12, 2020 05:55PM

I've tried that as well, but didn't worked.

ra...@google.com <ra...@google.com> #5May 12, 2020 05:57PM

Status: Won't Fix (Not Reproducible)

I request u 2 please resolve my problem I m very tired

ra...@google.com <ra...@google.com> #6May 12, 2020 05:57PM

The setting has only one msg in it that "setting has stopped" please resolve this problem also

ar...@gmail.com <ar...@gmail.com> #7May 12, 2020 06:12PM

Please try the the snippet below. It should work.

        cameraController.getInitializationFuture().addListener({
            cameraController.bindToLifecycle(activity)
            cameraController.setZoomRatio(1.5f)

            // The following codes are needed if you want to keep the zoom ratio 1.5x after stop/start the activity or fragment. 
            cameraController.cameraInfo!!.cameraState.removeObservers(activity)
            cameraController.cameraInfo!!.cameraState.observe(activity) {
                if (it.type == CameraState.Type.OPEN || it.type == CameraState.Type.OPEN) {
                    cameraController.setZoomRatio(1.5f)
                }
            }
        }, ContextCompat.getMainExecutor(applicationContext))

+Xi to see if there is a better approach.

worker.txt

15 KB

View

Download

ra...@google.com <ra...@google.com> #8May 12, 2020 06:29PM

Assigned to ra...@google.com.

The above solution is working as expected. Thanks!

ap...@google.com <ap...@google.com> #9May 12, 2020 08:04PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 19a88266d210181cd3ee7fa742eebdb4d57a678b
Author: Xi Zhang <xizh@google.com>
Date: Wed Jan 04 10:38:27 2023

Cleanup: remove unused code in CameraController.

The Display object and the TapToFocusStates annotation are no longer used.

Bug: 264157663
Test: manual test and ./gradlew bOS
Change-Id: I4d20d52e6e0e7bac1ae5e7cce3d358f24800c024

M camera/camera-view/src/androidTest/java/androidx/camera/view/PreviewViewDeviceTest.kt
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
M camera/camera-view/src/main/java/androidx/camera/view/PreviewView.java

https://android-review.googlesource.com/2376060

ar...@gmail.com <ar...@gmail.com> #10May 13, 2020 05:40AM

Project: platform/frameworks/support
Branch: androidx-main

commit 0a95adb75d68ecc43e27640e913ee876193b9b09
Author: Xi Zhang <xizh@google.com>
Date: Wed Jan 04 11:49:16 2023

Cleanup: create a wrapper interface for ProcessCameraProvider for injecting dependencies in unit tests.

It's hard to fake ProcessCameraProvider in unit tests. This CL creates a wrapper interface for ProcessCameraProvider so that it can be faked. This allows us to test initialization related code with unit tests.

- Create a ProcessCameraProviderWrapper with all the methods needed by CameraController.
- Create a ProcessCameraProviderWrapperImpl that wraps the real object.
- Add two tests for delayed initialization.

Bug: 264157663
Test: manual test and ./gradlew bOS
Change-Id: I1848135d58550ee1f1628f50075fff73e42896e5

M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
M camera/camera-view/src/main/java/androidx/camera/view/LifecycleCameraController.java
A camera/camera-view/src/main/java/androidx/camera/view/ProcessCameraProviderWrapper.java
A camera/camera-view/src/main/java/androidx/camera/view/ProcessCameraProviderWrapperImpl.java
M camera/camera-view/src/test/java/androidx/camera/view/CameraControllerTest.kt
A camera/camera-view/src/test/java/androidx/camera/view/FakeProcessCameraProviderWrapper.kt

https://android-review.googlesource.com/2376067

ra...@google.com <ra...@google.com> #11May 13, 2020 02:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1bd96bc31127f262b206dcf15b3897b79dc5a039
Author: Xi Zhang <xizh@google.com>
Date: Fri Jan 06 09:58:01 2023

In CameraController, allow setting CameraControl values before init

Save pending values and wait for the init to complete before setting them.

- Create a PendingValue class. This represents a pending CameraControl value set before init.
- In CameraController, if setting CameraControl values before init, set the PendingValue instead.
- In CameraController, once init completes, propagate the pending values. If init/bindToLifecycle fails, no-op and continue to wait.
- Updated FakeCameraControl to track the latest zoom and torch values.

Relnote: when setting torch/zoom prior before camera initialization compelets, e.g. calling CameraController#enableTorch, the pending action is cached and submitted once the initialization compeltes.

Bug: 264157663
Test: manual test and ./gradlew bOS
Change-Id: I11e926246983a760b0e65652abe89c67f6434cff

M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCamera.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCameraControl.java
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
A camera/camera-view/src/main/java/androidx/camera/view/PendingValue.java
M camera/camera-view/src/test/java/androidx/camera/view/CameraControllerTest.kt
M camera/camera-view/src/test/java/androidx/camera/view/FakeProcessCameraProviderWrapper.kt
A camera/camera-view/src/test/java/androidx/camera/view/PendingValueTest.kt

https://android-review.googlesource.com/2375805

ar...@gmail.com <ar...@gmail.com> #12May 13, 2020 03:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-view:1.3.0-alpha03

ra...@google.com <ra...@google.com> #13May 13, 2020 03:43PM

Just wanted to let know that the solution in the comment #7 is not working across all devices. For e.g. Not working in Pixel 5A.