Support linking compositions created on ViewGroups to parent CompositionReferences [156527485]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

May 13, 2020 10:17PM

I’ve got a view/composable structure like this:

@Composable Foo() {
    Providers(MyAmbient provides foo) {
        // <-- [REF] Capture the composition here…
        AndroidView(R.layout.bar) { view ->
            view.setContent {
                // <-- [DEREF] …and resume it here.
                Baz(MyAmbient.current)
            }
        }
    }
}

And I want that innermost composable to be able to access ambients from the outer one.

The way to do this is first to call compositionReference() on the line commented [REF], and then use it to create the composition on the line above [DEREF]. compositionReference() is a public function, and works as expected. Compose APIs such compositionFor() and subcomposeInto() accept a CompositionReference parameter, but are lower-level than is convenient to use from regular view code (they require dealing with ComponentNodes). There's currently no way to pass the CompositionReference into the child composition.

The simplest way to support this would be for ViewGroup.setContent to take an optional CompositionReference parameter and plumb it through to the deepest compositionFor call. I've proven this works using reflection to access private APIs here.

This was initially discussed in this Slack thread.

Comments

le...@google.com <le...@google.com> #2May 14, 2020 12:23AM

Assigned to po...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

an...@google.com <an...@google.com> #3May 14, 2020 10:09AM

I agree the proposed fix is a way to go. we should also migrate to start using it in our Popup and Dialog

po...@google.com <po...@google.com> #4May 14, 2020 12:11PM

Yes, this is surely needed. b/154369470 is tracking the symptom of this in Dialog.

ap...@google.com <ap...@google.com> #5Jun 25, 2020 07:27PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b300d2cd6ccab823bf4dea7fea62d52f9e6ed53c
Author: Mihai Popa <popam@google.com>
Date: Tue Jun 23 16:25:50 2020

Link ViewGroup compositions to existing ones

The CL adds API to link the compositions started via
ViewGroup#setContent to the enclosing composition. This enables proper
invalidations and ambients propagation across the subcomposition border.
Based on this API, Dialogs, Popups and DropdownMenus are now able to inherit
ambients (e.g. MaterialTheme) from the wrapping composition.

Relnote: Popups, Dialogs and Menus are now inheriting the contextual MaterialTheme
Bug: 156527485
Bug: 144091550
Bug: 158804197
Bug: 158794412
Test: WrapperTest, PopupTest, DialogTest
Change-Id: Ia3665905218b4d12d7a9bd121a69a51569d82694

M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/PopupTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/test/WrapperTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/Popup.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/Wrapper.kt
M ui/ui-desktop/src/jvmMain/kotlin/androidx/ui/desktop/Wrapper.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DialogUiTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-material/src/main/java/androidx/ui/material/AlertDialog.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ActivityWithActionBar.kt

https://android-review.googlesource.com/1347523

po...@google.com <po...@google.com> Jun 26, 2020 12:28AM

Marked as fixed.

Issue 156527485