Fixed
Status Update
Comments
le...@google.com <le...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
an...@google.com <an...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
po...@google.com <po...@google.com> #4
deleted
ap...@google.com <ap...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
Description
I’ve got a view/composable structure like this:
And I want that innermost composable to be able to access ambients from the outer one.
The way to do this is first to call
compositionReference()
on the line commented[REF]
, and then use it to create the composition on the line above[DEREF]
.compositionReference()
is a public function, and works as expected. Compose APIs suchcompositionFor()
andsubcomposeInto()
accept aCompositionReference
parameter, but are lower-level than is convenient to use from regular view code (they require dealing withComponentNode
s). There's currently no way to pass theCompositionReference
into the child composition.The simplest way to support this would be for here .
ViewGroup.setContent
to take an optionalCompositionReference
parameter and plumb it through to the deepestcompositionFor
call. I've proven this works using reflection to access private APIsThis was initially discussed in this Slack thread .