Fixed
Status Update
No update yet.
Comments
ap...@google.com
Hi. Thanks for reporting this. Fixed in alpha-04
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
an...@google.com
deleted
il...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
mi...@gmail.com
There is a bug in NavController (line 1078):
mBackStack.peekLast().getArguments().putAll(args);
When getArguments(). return null, NPE is thrown.
mBackStack.peekLast().getArguments().putAll(args);
When getArguments(). return null, NPE is thrown.
mi...@gmail.com
Basically this is a case when current (old) fragment was created without arguments, but new navigation event has bundle args.
il...@google.com
Re #6 - I filed
Description
Component used: Navigation Version used: 2.3.0-alpha06
When navigating to a destination with single top, the arguments could change, but the
NavBackStackEntry's arguments (because it isn't a new instance ofNavBackStackEntry) aren't updated. It also means they aren't fed through to anyOnDestinationChangedListenerinstances.I would expect that the arguments would be updated and that any listeners would get a callback (the destination wouldn't change, but the arguments would).