ActivityResultContracts.TakePicture doesn't handle the case where no activity can handle the intent [156875743]

Fixed

Bug

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

May 18, 2020 01:06PM

Component used: Activity Version used: 1.2.0-alpha04 Devices/Android versions reproduced on: Pixel 3 / Android 10

From the "Take photos" docs:

Notice that the startActivityForResult() method is protected by a condition that calls resolveActivity(), which returns the first activity component that can handle the intent. Performing this check is important because if you call startActivityForResult() using an intent that no app can handle, your app will crash. So as long as the result is not null, it's safe to use the intent.

ActivityResultContracts.TakePicture doesn't perform this check, so if there's no activity that can handle its intent, the app will crash. I'd guess this applies for TakePicturePreview and TakeVideo as well.

I personally don't see an easy fix for this given the current API, and at the same time I wouldn't like to see the API getting more complicated to accommodate this. I'm currently happy using the simple ActivityResultContracts.StartActivityForResult so I can fully control the intent creation plus other relevant things like saving the file path properly so I don't lose it in case of process death.

Comments

jb...@google.com <jb...@google.com> May 26, 2020 08:43PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2May 27, 2020 12:06AM

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

ap...@google.com <ap...@google.com> #3May 27, 2020 04:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

jb...@google.com <jb...@google.com> #4May 27, 2020 05:02PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

il...@google.com <il...@google.com> #5May 27, 2020 05:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333

Issue 156875743