ActivityResultContracts.TakePicture doesn't handle the case where no activity can handle the intent [156875743]

Fixed

Bug

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

May 18, 2020 01:06PM

Component used: Activity Version used: 1.2.0-alpha04 Devices/Android versions reproduced on: Pixel 3 / Android 10

From the "Take photos" docs:

Notice that the startActivityForResult() method is protected by a condition that calls resolveActivity(), which returns the first activity component that can handle the intent. Performing this check is important because if you call startActivityForResult() using an intent that no app can handle, your app will crash. So as long as the result is not null, it's safe to use the intent.

ActivityResultContracts.TakePicture doesn't perform this check, so if there's no activity that can handle its intent, the app will crash. I'd guess this applies for TakePicturePreview and TakeVideo as well.

I personally don't see an easy fix for this given the current API, and at the same time I wouldn't like to see the API getting more complicated to accommodate this. I'm currently happy using the simple ActivityResultContracts.StartActivityForResult so I can fully control the intent creation plus other relevant things like saving the file path properly so I don't lose it in case of process death.

Comments

jb...@google.com <jb...@google.com> May 26, 2020 08:43PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2May 27, 2020 12:06AM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

ap...@google.com <ap...@google.com> #3May 27, 2020 04:23PM

Great! Thanks a lot, I'll look for the live updates soon!

jb...@google.com <jb...@google.com> #4May 27, 2020 05:02PM

Marked as fixed.

This has been fixed internally and will be available in the Activity 1.2.0-alpha06 release.

To address this the ActivityResultLauncher now gives access to the ActivityResultContract.

With the contract, you can create the intent and use it to call resolveActivity() directly:

launcher.contract.createIntent(context, input).resolveActivity(packageManager)

il...@google.com <il...@google.com> #5May 27, 2020 05:07PM

Keep in mind that due to the Package visibility changes in Android 11, by default, resolveActivity() will return null unless you add the specific <queries> elements to your manifest.

As per that doc, the alternative is to catch the ActivityNotFoundException yourself by wrapping your launch() call in a try / catch, just like if you were using startActivityForResult() yourself.

Issue 156875743