Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug: b/161809385
Bug: b/161807956
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
ma...@google.com <ma...@google.com> #3
Louis, as discussed, please take a look when you have time
lp...@google.com <lp...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 132f9fad979d8fee43af2d17df2937131b871849
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Feb 01 19:42:04 2021
Changes Indication#createInstance to be @Composable
Changes LocalIndication to just contain the type Indication instead of a lambda returning Indication
Indication can now just be treated as a factory for IndicationInstance and there do not need to be multiple Indication instances across the hierarchy. createInstance() can query theme CompositionLocals directly for any theme information that depends on where the Modifier.indication() is invoked in the hierarchy.
Also changes Surface to provide ambients outside the LayoutNode with modifiers - this means that ripples applied directly to the Surface will now consume the content color provided by the Surface, instead of the nearest parent provider outside the Surface.
Bug: b/157150564
Test: MaterialRippleThemeTest
Test: SurfaceTest
Relnote: "Changed Indication#createInstance to be @Composable, and changed LocalIndication to contain an Indication, not () -> Indication."
Change-Id: I5eeea2424e4deda6116f0b48b690b628f8d545eb
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/IndicationSamples.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/InteractionStateSample.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/IndicationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Clickable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Indication.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Selectable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
M compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/Ripple.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialRippleThemeTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SurfaceTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTheme.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Surface.kt
https://android-review.googlesource.com/1567760
Branch: androidx-main
commit 132f9fad979d8fee43af2d17df2937131b871849
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Feb 01 19:42:04 2021
Changes Indication#createInstance to be @Composable
Changes LocalIndication to just contain the type Indication instead of a lambda returning Indication
Indication can now just be treated as a factory for IndicationInstance and there do not need to be multiple Indication instances across the hierarchy. createInstance() can query theme CompositionLocals directly for any theme information that depends on where the Modifier.indication() is invoked in the hierarchy.
Also changes Surface to provide ambients outside the LayoutNode with modifiers - this means that ripples applied directly to the Surface will now consume the content color provided by the Surface, instead of the nearest parent provider outside the Surface.
Bug:
Test: MaterialRippleThemeTest
Test: SurfaceTest
Relnote: "Changed Indication#createInstance to be @Composable, and changed LocalIndication to contain an Indication, not () -> Indication."
Change-Id: I5eeea2424e4deda6116f0b48b690b628f8d545eb
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/IndicationSamples.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/InteractionStateSample.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/IndicationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Clickable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Indication.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Selectable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
M compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/Ripple.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialRippleThemeTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SurfaceTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTheme.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Surface.kt
Description
No description yet.