Fixed
Status Update
Comments
st...@gmail.com <st...@gmail.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
sh...@google.com <sh...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
yb...@google.com <yb...@google.com> #4
deleted
yb...@google.com <yb...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
st...@gmail.com <st...@gmail.com> #7
Thanks for the fix, folks! :)
Description
androidx.recyclerview:recyclerview:1.2.0-alpha03
First of all, thank you for the new
MergeAdapter
! This is my first time using and benefiting from it.When I create a merge adapter configuration via
MergeAdapter.Config.Builder().build()
, I receive a configuration withConfig::isolateViewTypes
set tofalse
. The value of this same field inMergeAdapter.Config::DEFAULT
istrue
.This violated the principle of least surprise for me. I was evolving code that initially used "no" (= the default) configuration:
I wanted to update this code to change the stable ID mode. I tried to achieve that by building and passing in a custom configuration:
but this temporarily broke my code because view type isolation changed compared to the initial code. I instead needed to explicitly write
to retain default view type isolation behavior.
Please evaluate whether it would be less surprising to initialize
in
MergeAdapter.Config::Builder
instead!