Fixed
Status Update
Comments
st...@gmail.com <st...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
sh...@google.com <sh...@google.com> #3
since it is already marked as deprecated, we can probably do it by now.
yb...@google.com <yb...@google.com> #4
Opening diff shortly
yb...@google.com <yb...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
st...@gmail.com <st...@gmail.com> #7
Thanks for the fix, folks! :)
Description
androidx.recyclerview:recyclerview:1.2.0-alpha03
First of all, thank you for the new
MergeAdapter
! This is my first time using and benefiting from it.When I create a merge adapter configuration via
MergeAdapter.Config.Builder().build()
, I receive a configuration withConfig::isolateViewTypes
set tofalse
. The value of this same field inMergeAdapter.Config::DEFAULT
istrue
.This violated the principle of least surprise for me. I was evolving code that initially used "no" (= the default) configuration:
I wanted to update this code to change the stable ID mode. I tried to achieve that by building and passing in a custom configuration:
but this temporarily broke my code because view type isolation changed compared to the initial code. I instead needed to explicitly write
to retain default view type isolation behavior.
Please evaluate whether it would be less surprising to initialize
in
MergeAdapter.Config::Builder
instead!