TestTag should be @Deprecated [157173105]

Fixed

Bug

Status Update

No update yet.

Description

mo...@google.com

created issue #1

May 20, 2020 10:57PM

Now that semantics is a modifier, TestTag should be a modifier also.

Comments

ap...@google.com <ap...@google.com> #2May 27, 2020 04:15PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3May 27, 2020 06:04PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6de64f594ea3b44c08717811b10ed31f74b5e013
Author: Filip Pavlis <pavlis@google.com>
Date: Wed May 27 18:11:55 2020

Replace TestTag with modifier in foundation tests.

Bug: 157173105
Test: N/A
Change-Id: Id1c630433a9fec0e6da44b6dbd97f37ed0985244

M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/BorderTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/BoxTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/CanvasTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTextTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DraggableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DrawBackgroundTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ImageTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/IndicationTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ScrollableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldFocusTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldOnValueChangeTextFieldValueTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ToggleableTest.kt

https://android-review.googlesource.com/1319014

ae...@google.com <ae...@google.com> #4May 27, 2020 10:27PM

Reassigned to ae...@google.com.

Thanks for working on this. I hope to be able to land https://android-review.googlesource.com/c/platform/frameworks/support/+/1314785 soon if nothing major comes up in code review, which I rebased to remove 'container = true' from the modifier-based tests (since I removed that API from the modifier-based one as part of the patch).

I'm preparing a patch to convert the remaining tests in ui-core/ and ui-test/ package and remove 'container = true' in one go, so assigning to myself.

ap...@google.com <ap...@google.com> #5May 28, 2020 06:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5c8252f6a2d2d05025476a0fd87efb70e2feac7a
Author: Alexandre Elias <aelias@google.com>
Date: Wed May 27 15:52:40 2020

Switch TestTag to modifiers in ui-core and ui-test

Bug: 157173105
Test: existing tests
Change-Id: Ib7e5f70af788e74bae0827e10b4bebbd4be0006a

M ui/ui-core/src/androidTest/java/androidx/ui/core/test/AndroidViewCompatTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertExistsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/BitmapCapturingTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/DumpToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindInPopupTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/MultipleActivitiesClickTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/MultipleActivitiesFindTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/MultipleComposeRootsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/util/BoundaryNodes.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/util/ClickableTestBox.kt

https://android-review.googlesource.com/1318945

ap...@google.com <ap...@google.com> #6May 30, 2020 03:33AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4f9fbcae6d2c450271554d86e6364ad15796f729
Author: Alexandre Elias <aelias@google.com>
Date: Thu May 28 17:58:43 2020

Deprecate TestTag and convert all remaining uses to modifier

- I also converted DeterminateProgressIndicator to a semantics modifier
to make it easier to attach testTag to.
- The DemoTests were already broken but this went unnoticed because
@LargeTests rarely run, so I fixed them and made the smaller ones
@MediumTest.
- I left some @Ignored ScaffoldTest as single-child-composable Semantics
as it was not clear how to correctly convert them (and they are
already broken so it's hard to confirm correctness), but removed usage
of TestTag as such.

Fixes: 157173105
Test: Existing tests
Relnote: "TestTag is now deprecated. Use Modifier.testTag instead."
Change-Id: If5110df5865f5933d10d54a8aacba58f8cd1c712

M ui/integration-tests/demos/src/androidTest/java/androidx/ui/demos/test/DemoTest.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoApp.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/framework/VectorAssetTestCase.kt
M ui/ui-core/api/0.1.0-dev14.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev14.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/main/java/androidx/ui/core/TestTag.kt
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DeterminateProgressSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DeterminateProgressTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/DeterminateProgressIndicator.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutOffsetTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/ProgressIndicator.kt

https://android-review.googlesource.com/1320146

Issue 157173105