Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1d4d1b83b4810e80d9aaddfdf34a142eb0389d19
Author: Filip Pavlis <pavlis@google.com>
Date: Wed May 27 14:45:15 2020
Replace TestTag with modifier in material tests.
Bug: 157173105
Test: N/A
Change-Id: I58cc9c533b71e0c638795a0a0f1765bedb7d76ee
M ui/ui-material/icons/extended/src/androidTest/java/androidx/ui/material/icons/test/IconComparisonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/DrawerTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ElevationOverlayTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/FilledTextFieldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/FloatingActionButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/MenuTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ProgressIndicatorTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioGroupUiTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RippleTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SliderTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
https://android-review.googlesource.com/1318475
Branch: androidx-master-dev
commit 1d4d1b83b4810e80d9aaddfdf34a142eb0389d19
Author: Filip Pavlis <pavlis@google.com>
Date: Wed May 27 14:45:15 2020
Replace TestTag with modifier in material tests.
Bug: 157173105
Test: N/A
Change-Id: I58cc9c533b71e0c638795a0a0f1765bedb7d76ee
M ui/ui-material/icons/extended/src/androidTest/java/androidx/ui/material/icons/test/IconComparisonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/DrawerTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ElevationOverlayTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/FilledTextFieldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/FloatingActionButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/MenuTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ProgressIndicatorTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioGroupUiTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RippleTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SliderTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SwitchUiTest.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6de64f594ea3b44c08717811b10ed31f74b5e013
Author: Filip Pavlis <pavlis@google.com>
Date: Wed May 27 18:11:55 2020
Replace TestTag with modifier in foundation tests.
Bug: 157173105
Test: N/A
Change-Id: Id1c630433a9fec0e6da44b6dbd97f37ed0985244
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/BorderTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/BoxTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/CanvasTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTextTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DraggableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DrawBackgroundTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ImageTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/IndicationTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ScrollableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldFocusTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldOnValueChangeTextFieldValueTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ToggleableTest.kt
https://android-review.googlesource.com/1319014
Branch: androidx-master-dev
commit 6de64f594ea3b44c08717811b10ed31f74b5e013
Author: Filip Pavlis <pavlis@google.com>
Date: Wed May 27 18:11:55 2020
Replace TestTag with modifier in foundation tests.
Bug: 157173105
Test: N/A
Change-Id: Id1c630433a9fec0e6da44b6dbd97f37ed0985244
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/BorderTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/BoxTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/CanvasTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTextTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DraggableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DrawBackgroundTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ImageTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/IndicationTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ScrollableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldFocusTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldOnValueChangeTextFieldValueTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ToggleableTest.kt
ae...@google.com <ae...@google.com> #4
Thanks for working on this. I hope to be able to land
I'm preparing a patch to convert the remaining tests in ui-core/ and ui-test/ package and remove 'container = true' in one go, so assigning to myself.
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5c8252f6a2d2d05025476a0fd87efb70e2feac7a
Author: Alexandre Elias <aelias@google.com>
Date: Wed May 27 15:52:40 2020
Switch TestTag to modifiers in ui-core and ui-test
Bug: 157173105
Test: existing tests
Change-Id: Ib7e5f70af788e74bae0827e10b4bebbd4be0006a
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/AndroidViewCompatTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertExistsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/BitmapCapturingTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/DumpToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindInPopupTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/MultipleActivitiesClickTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/MultipleActivitiesFindTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/MultipleComposeRootsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/util/BoundaryNodes.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/util/ClickableTestBox.kt
https://android-review.googlesource.com/1318945
Branch: androidx-master-dev
commit 5c8252f6a2d2d05025476a0fd87efb70e2feac7a
Author: Alexandre Elias <aelias@google.com>
Date: Wed May 27 15:52:40 2020
Switch TestTag to modifiers in ui-core and ui-test
Bug: 157173105
Test: existing tests
Change-Id: Ib7e5f70af788e74bae0827e10b4bebbd4be0006a
M ui/ui-core/src/androidTest/java/androidx/ui/core/test/AndroidViewCompatTest.kt
M ui/ui-core/src/androidTest/java/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertExistsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/BitmapCapturingTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/DumpToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindInPopupTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/MultipleActivitiesClickTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/MultipleActivitiesFindTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/MultipleComposeRootsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/util/BoundaryNodes.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/util/ClickableTestBox.kt
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4f9fbcae6d2c450271554d86e6364ad15796f729
Author: Alexandre Elias <aelias@google.com>
Date: Thu May 28 17:58:43 2020
Deprecate TestTag and convert all remaining uses to modifier
- I also converted DeterminateProgressIndicator to a semantics modifier
to make it easier to attach testTag to.
- The DemoTests were already broken but this went unnoticed because
@LargeTests rarely run, so I fixed them and made the smaller ones
@MediumTest.
- I left some @Ignored ScaffoldTest as single-child-composable Semantics
as it was not clear how to correctly convert them (and they are
already broken so it's hard to confirm correctness), but removed usage
of TestTag as such.
Fixes: 157173105
Test: Existing tests
Relnote: "TestTag is now deprecated. Use Modifier.testTag instead."
Change-Id: If5110df5865f5933d10d54a8aacba58f8cd1c712
M ui/integration-tests/demos/src/androidTest/java/androidx/ui/demos/test/DemoTest.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoApp.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/framework/VectorAssetTestCase.kt
M ui/ui-core/api/0.1.0-dev14.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev14.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/main/java/androidx/ui/core/TestTag.kt
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DeterminateProgressSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DeterminateProgressTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/DeterminateProgressIndicator.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutOffsetTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/ProgressIndicator.kt
https://android-review.googlesource.com/1320146
Branch: androidx-master-dev
commit 4f9fbcae6d2c450271554d86e6364ad15796f729
Author: Alexandre Elias <aelias@google.com>
Date: Thu May 28 17:58:43 2020
Deprecate TestTag and convert all remaining uses to modifier
- I also converted DeterminateProgressIndicator to a semantics modifier
to make it easier to attach testTag to.
- The DemoTests were already broken but this went unnoticed because
@LargeTests rarely run, so I fixed them and made the smaller ones
@MediumTest.
- I left some @Ignored ScaffoldTest as single-child-composable Semantics
as it was not clear how to correctly convert them (and they are
already broken so it's hard to confirm correctness), but removed usage
of TestTag as such.
Fixes: 157173105
Test: Existing tests
Relnote: "TestTag is now deprecated. Use Modifier.testTag instead."
Change-Id: If5110df5865f5933d10d54a8aacba58f8cd1c712
M ui/integration-tests/demos/src/androidTest/java/androidx/ui/demos/test/DemoTest.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoApp.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/framework/VectorAssetTestCase.kt
M ui/ui-core/api/0.1.0-dev14.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev14.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/main/java/androidx/ui/core/TestTag.kt
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DeterminateProgressSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DeterminateProgressTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/DeterminateProgressIndicator.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutOffsetTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/ProgressIndicator.kt
Description
Now that semantics is a modifier, TestTag should be a modifier also.