TestTag should be @Deprecated [157173105]

Fixed

Bug

Status Update

No update yet.

Description

mo...@google.com

created issue #1

May 20, 2020 10:57PM

Now that semantics is a modifier, TestTag should be a modifier also.

Comments

ap...@google.com <ap...@google.com> #2May 27, 2020 04:15PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ap...@google.com <ap...@google.com> #3May 27, 2020 06:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ae...@google.com <ae...@google.com> #4May 27, 2020 10:27PM

Reassigned to ae...@google.com.

deleted

ap...@google.com <ap...@google.com> #5May 28, 2020 06:44PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6May 30, 2020 03:33AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4f9fbcae6d2c450271554d86e6364ad15796f729
Author: Alexandre Elias <aelias@google.com>
Date: Thu May 28 17:58:43 2020

Deprecate TestTag and convert all remaining uses to modifier

- I also converted DeterminateProgressIndicator to a semantics modifier
to make it easier to attach testTag to.
- The DemoTests were already broken but this went unnoticed because
@LargeTests rarely run, so I fixed them and made the smaller ones
@MediumTest.
- I left some @Ignored ScaffoldTest as single-child-composable Semantics
as it was not clear how to correctly convert them (and they are
already broken so it's hard to confirm correctness), but removed usage
of TestTag as such.

Fixes: 157173105
Test: Existing tests
Relnote: "TestTag is now deprecated. Use Modifier.testTag instead."
Change-Id: If5110df5865f5933d10d54a8aacba58f8cd1c712

M ui/integration-tests/demos/src/androidTest/java/androidx/ui/demos/test/DemoTest.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoApp.kt
M ui/integration-tests/src/main/java/androidx/ui/integration/test/framework/VectorAssetTestCase.kt
M ui/ui-core/api/0.1.0-dev14.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev14.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/main/java/androidx/ui/core/TestTag.kt
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DeterminateProgressSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DeterminateProgressTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/DeterminateProgressIndicator.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutOffsetTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/ProgressIndicator.kt

https://android-review.googlesource.com/1320146

Issue 157173105