ActivityResult should have destructuring Kotlin extensions [157212935]

Fixed

Feature Request

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

May 22, 2020 03:24AM

Component used: Activity Version used: 1.2.0-alpha05

It would be really convenient if ActivityResult had Kotlin destructuring extensions.

This would allow you to replace:

private val setupLauncher = registerForActivityResult(
        ActivityResultContracts.StartActivityForResult()) { activityResult ->
    // Handle the result
}

With code that gives direct access to the result code and data:

private val setupLauncher = registerForActivityResult(
        ActivityResultContracts.StartActivityForResult()) { (resultCode, data) ->
    // Handle the result
}

Comments

il...@google.com <il...@google.com> May 26, 2020 06:46PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2May 26, 2020 10:47PM

We'd accept a pull request for this if you'd like to contribute to AndroidX.

jb...@google.com <jb...@google.com> #3May 26, 2020 11:04PM

Marked as fixed.

Absolutely, here is one: https://android-review.googlesource.com/c/platform/frameworks/support/+/1498197

ju...@gmail.com <ju...@gmail.com> #4Jan 24, 2021 04:48PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 205ca48fd552f665e52647b3bbee63839c7bd897
Author: Nicklas Ansman Giertz <nicklas@ansman.se>
Date: Thu Nov 12 21:57:48 2020

Migrate ShareCompat factory methods to constructors

The `from` methods for creating IntentBuilders and IntentReaders has
been deprecated and the constructor has been made public.

In addition to this there are now two ways of creating each class, one
from an Activity and one from the raw components.

Fixes: 173043501
Test: ShareCompatTest
Relnote: "ShareCompat now uses constructors for creation and the old
factory methods have been deprecated. You can now create both builders
and readers from a Context and an Activity is no longer required."

Change-Id: I315b68aff01ca931d38b934786e6d9b2174f720b

M core/core/api/current.txt
M core/core/api/public_plus_experimental_current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/app/ShareCompatTest.java
M core/core/src/main/java/androidx/core/app/ShareCompat.java

https://android-review.googlesource.com/1498197

Issue 157212935

Description

Issue summary

Comments

il...@google.com <il...@google.com> May 26, 2020 06:46PM

ap...@google.com <ap...@google.com> #2May 26, 2020 10:47PM

jb...@google.com <jb...@google.com> #3May 26, 2020 11:04PM

ju...@gmail.com <ju...@gmail.com> #4Jan 24, 2021 04:48PM

Add comment

Issue metadata