Change ActivityResultRegistry invoke() to onLaunch() [157496491]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

May 26, 2020 08:21PM

The invoke() method is the only API exposed from ActivityResultRegistry. This used to make since because ActivityResultLauncher used the kotlin invoke() and invoking the launcher would call invoke() on the registry. Since ActivityResultLauncher has moved to using launch() this connection is no longer clear.

We should change the invoke() in ActivityResultRegistry to be onLaunch() so it is clear that it is executed once the call to launch() is made.

Comments

ap...@google.com <ap...@google.com> #2May 26, 2020 09:33PM

seems to be dup: b/212982460

jb...@google.com <jb...@google.com> #3May 26, 2020 09:36PM

Marked as fixed.

Fundamentally the issue here is that the selection logic happening in composition depends on the text layout result which is available on measure. So we end up using stale TextLayoutResult which causes the issue.

Issue 157496491

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 26, 2020 09:33PM

jb...@google.com <jb...@google.com> #3May 26, 2020 09:36PM

Add comment

Issue metadata