IssueTracker

CAMERAX VERSION (1.0.0-beta03, camera-view:1.0.0-alpha10)

ANDROID OS BUILD NUMBER: (Samsung SM-A300H version 5.0.2)

DEVICE NAME: (Samsung Galaxy A3)

DESCRIPTION:

I'm adding camerax to app and my tester find issue on one device - when use ImageCapture.FLASH_MODE_AUTO and capture image in dark when flash triggered - app crashed

Fatal Exception: java.lang.RuntimeException
startPreview failed

android.hardware.Camera.startPreview (Camera.java)
android.hardware.camera2.legacy.RequestThreadManager.startPreview (RequestThreadManager.java:275)
android.hardware.camera2.legacy.RequestThreadManager.doPreviewCapture (RequestThreadManager.java:317)
android.hardware.camera2.legacy.RequestThreadManager.access$1600 (RequestThreadManager.java:61)
android.hardware.camera2.legacy.RequestThreadManager$5.handleMessage (RequestThreadManager.java:756)
android.os.Handler.dispatchMessage (Handler.java:98)
android.os.Looper.loop (Looper.java:135)
android.os.HandlerThread.run (HandlerThread.java:61)

STEPS TO REPRODUCE:
1. use Samsung Galaxy A3
2. set ImageCapture.FLASH_MODE_AUTO
3. take a picture in dark

OBSERVED RESULTS:
app crashed

EXPECTED RESULTS:
taking picture or handle exception

REPRODUCIBILITY: (5 of 5, 1 of 100, etc)
5 of 5

ADDITIONAL INFORMATION:

In our log I see different crash:

Throwable occurred: androidx.camera.core.ImageCaptureException: Camera is closed.
        at androidx.camera.core.ImageCapture$ImageCaptureRequest.lambda$notifyCallbackError$1$ImageCapture$ImageCaptureRequest(ImageCapture.java:1963)
        at androidx.camera.core.-$$Lambda$ImageCapture$ImageCaptureRequest$1G7WSvt8TANxhZtOyewefm68pg4.run(lambda)
        at android.os.Handler.handleCallback(Handler.java:739)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:135)
        at android.app.ActivityThread.main(ActivityThread.java:5536)
        at java.lang.reflect.Method.invoke(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:372)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1397)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1192)
Caused by: androidx.camera.core.CameraClosedException: Camera is closed.
        at androidx.camera.core.ImageCapture.abortImageCaptureRequests(ImageCapture.java:703)
        at androidx.camera.core.ImageCapture.onStateOffline(ImageCapture.java:699)
        at androidx.camera.camera2.internal.Camera2CameraImpl.lambda$notifyStateOfflineToUseCases$12(Camera2CameraImpl.java:689)
        at androidx.camera.camera2.internal.-$$Lambda$Camera2CameraImpl$hp2EIAmfp4eGOX-qpuivXiBeeMA.run(lambda)

CODE FRAGMENTS (this will help us troubleshoot your issues):

this is how I bindCameraUseCases

 val metrics = DisplayMetrics().also { viewFinder.display.getRealMetrics(it) }
        val screenAspectRatio = aspectRatio(metrics.widthPixels, metrics.heightPixels)
        val rotation = viewFinder.display.rotation
        val cameraSelector = CameraSelector.Builder().requireLensFacing(lensFacing).build()
        val cameraProviderFuture = ProcessCameraProvider.getInstance(this)
        cameraProviderFuture.addListener(Runnable {
            val cameraProvider: ProcessCameraProvider = cameraProviderFuture.get()
            preview = Preview.Builder()
                    .setTargetAspectRatio(screenAspectRatio)
                    .setTargetRotation(rotation)
                    .build()
            imageCapture = ImageCapture.Builder()
                    .setCaptureMode(ImageCapture.CAPTURE_MODE_MINIMIZE_LATENCY)
                    .setTargetAspectRatio(screenAspectRatio)
                    .setTargetRotation(rotation)
                    .setFlashMode(ImageCapture.FLASH_MODE_AUTO)
                    .build()
           
            cameraProvider.unbindAll()
            try {
                camera = cameraProvider.bindToLifecycle(this, cameraSelector, preview, imageCapture)
                preview?.setSurfaceProvider(viewFinder.createSurfaceProvider(camera?.cameraInfo))
            } catch (exc: Exception) {
            }

        }, ContextCompat.getMainExecutor(this))


    private fun aspectRatio(width: Int, height: Int): Int {
        val previewRatio = max(width, height).toDouble() / min(width, height)
        if (abs(previewRatio - RATIO_4_3_VALUE) <= abs(previewRatio - RATIO_16_9_VALUE)) {
            return AspectRatio.RATIO_4_3
        }
        return AspectRatio.RATIO_16_9
    }

This is how I set imageCaptureLitener

                imageCapture?.let { imageCapture ->
                    val photoFile = createFile()
                    val metadata = ImageCapture.Metadata().apply {
                        isReversedHorizontal = lensFacing == CameraSelector.LENS_FACING_FRONT
                    }
                    val outputOptions = ImageCapture.OutputFileOptions.Builder(photoFile)
                            .setMetadata(metadata)
                            .build()
                    imageCapture.takePicture(outputOptions, cameraExecutor, object : ImageCapture.OnImageSavedCallback {
                        override fun onError(exc: ImageCaptureException) {
                        }

                        override fun onImageSaved(output: ImageCapture.OutputFileResults) {
                            setGalleryThumbnail(photoFile.path)
                            valuesList.add(0, photoFile.path)
                        }
                    })
                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
                        container.postDelayed({
                            container.foreground = ColorDrawable(Color.WHITE)
                            container.postDelayed(
                                    { container.foreground = null }, ANIMATION_FAST_MILLIS)
                        }, ANIMATION_SLOW_MILLIS)
                    }
                }