Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6788d20ba865fee90b162faa6ae4d5c4c6b66d92
Author: Matvei Malkov <malkov@google.com>
Date: Thu May 28 18:35:55 2020
Replace MutuallyExclusiveSetItem with Modifier.Selectable.
Last foundation interaction has been moved to modifiers here. Also with indication and interactionState support to bring together these pieces.
Since it's not an Item anymore, I chencged the name from MutuallyExclusiveSetItem to Selectable, as it's selectable within this set, to makes sense to me. I also added boolean param to control whether it's in the set or just a single value.
Change-Id: I02b473710e5a654427b51565c0b950392f68fcff
Relnote: MutuallyExclusiveSetItem has been deprecated. Use Modifier.selectable instead.
Bug: 157642842
Test: has been changed to work with new modifier
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
A ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/SelectableSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SelectableTest.kt
D ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/MutuallyExclusiveSetItem.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/TopAppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/BottomNavigation.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
https://android-review.googlesource.com/1318898
Branch: androidx-master-dev
commit 6788d20ba865fee90b162faa6ae4d5c4c6b66d92
Author: Matvei Malkov <malkov@google.com>
Date: Thu May 28 18:35:55 2020
Replace MutuallyExclusiveSetItem with Modifier.Selectable.
Last foundation interaction has been moved to modifiers here. Also with indication and interactionState support to bring together these pieces.
Since it's not an Item anymore, I chencged the name from MutuallyExclusiveSetItem to Selectable, as it's selectable within this set, to makes sense to me. I also added boolean param to control whether it's in the set or just a single value.
Change-Id: I02b473710e5a654427b51565c0b950392f68fcff
Relnote: MutuallyExclusiveSetItem has been deprecated. Use Modifier.selectable instead.
Bug: 157642842
Test: has been changed to work with new modifier
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
A ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/SelectableSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SelectableTest.kt
D ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/MutuallyExclusiveSetItem.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/TopAppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/BottomNavigation.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 852980c73a7ba8b2fceef531a122e6d24c839202
Author: Matvei Malkov <malkov@google.com>
Date: Thu May 28 17:53:26 2020
Make Toggleable be Modifier.toggleable
This CL makes Toggleable component be just a modifier, while also adding features presented in Modifier.clickable (interactonState, indication)
Relnote: Toggleable component has been deprecated. Use Modifier.toggleable instead
Bug:157642842
Test: converted
Change-Id: I35220fca0d9d11198d1158cb905cfb2586965a34
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ToggleableSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ToggleableTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-material/src/main/java/androidx/ui/material/Checkbox.kt
M ui/ui-material/src/main/java/androidx/ui/material/IconButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
https://android-review.googlesource.com/1318897
Branch: androidx-master-dev
commit 852980c73a7ba8b2fceef531a122e6d24c839202
Author: Matvei Malkov <malkov@google.com>
Date: Thu May 28 17:53:26 2020
Make Toggleable be Modifier.toggleable
This CL makes Toggleable component be just a modifier, while also adding features presented in Modifier.clickable (interactonState, indication)
Relnote: Toggleable component has been deprecated. Use Modifier.toggleable instead
Bug:157642842
Test: converted
Change-Id: I35220fca0d9d11198d1158cb905cfb2586965a34
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ToggleableSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ToggleableTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-material/src/main/java/androidx/ui/material/Checkbox.kt
M ui/ui-material/src/main/java/androidx/ui/material/IconButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
ma...@google.com <ma...@google.com> #4
both toggeable and mutuallyExclusive set were migrated to modifiers
Description