DropdownMenuItem 'onClick' listener is never invoked [157673259]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

May 28, 2020 09:17PM

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply
all required information.

Android Studio Build: 4.1 canary 8
Version of Gradle Plugin:4.1.0-alpha08
Version of Gradle: 6.3
Version of Java: 8
OS: Android 10

Steps to Reproduce:
1. Create a simple Composable function with a DropDownMenu and a DropDownItem from ui-material
2. Pass a listener through the 'onClick' parameter of DropDownItem
3. The passed listener will never be invoked

Reading the source code of DropDownItem, I found that the cause of the problem is a ripple modifier, applied after the clickable one.

Comments

cl...@google.com <cl...@google.com> #2May 29, 2020 11:43AM

Assigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3d00acd443e0e5dd2cc33eb314a65f78f21cec61
Author: Calin Tataru <calintat@google.com>
Date: Mon Aug 10 17:59:53 2020

Modifier.swipeable polishing

This CL does the following things:
* Expand the documentation in SwipeableState.
* Make the setter of SwipeableState.value private.
* Rename some of the properties in SwipeableState, and slightly change
the definition of swipeTarget (now called targetValue) so that it uses
the target value of the ongoing animation if isAnimationRunning = true.
* Add a rememberSwipeableState function to help reduce boilerplate.
* Add Savers for [Drawer/BottomDrawer/Dismiss/Swipeable]State, so that
we can use rememberSavedInstanceState in the rememberFooState functions.

Bug: 163129614
Bug: 163132293
Test: Ran SwipeableTest and other tests depending on swipeable
Relnote: "Renamed some properties in SwipeableState: swipeTarget ->
targetValue, swipeProgress -> progress, swipeDirection -> direction.
Added a rememberSwipeableState function for creating SwipeableStates."
Change-Id: I2fc9c3af465b579a18359ae0aa0853c2d2b02abe

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/SwipeToDismissSamples.kt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/SwipeableSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/SwipeableTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/SwipeToDismiss.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Swipeable.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/Switch.kt

https://android-review.googlesource.com/1396349

po...@google.com <po...@google.com> #3May 29, 2020 12:27PM

Reassigned to po...@google.com.

I added a rememberSwipeableState function to easily create and remember a SwipeableState with the default animation clock. That should work perfectly for your usecase.

ma...@google.com <ma...@google.com> #4May 29, 2020 02:10PM

Regression in material3: the function is now marked internal. Please re-open.

po...@google.com <po...@google.com> Jun 1, 2020 07:47PM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Jun 1, 2020 07:48PM

https://cs.android.com/androidx/platform/frameworks/support/+/4e99cad7cfba400da47af86a08f68df6b40c6e51

Issue 157673259