DropdownMenuItem 'onClick' listener is never invoked [157673259]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

May 28, 2020 09:17PM

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply
all required information.

Android Studio Build: 4.1 canary 8
Version of Gradle Plugin:4.1.0-alpha08
Version of Gradle: 6.3
Version of Java: 8
OS: Android 10

Steps to Reproduce:
1. Create a simple Composable function with a DropDownMenu and a DropDownItem from ui-material
2. Pass a listener through the 'onClick' parameter of DropDownItem
3. The passed listener will never be invoked

Reading the source code of DropDownItem, I found that the cause of the problem is a ripple modifier, applied after the clickable one.

Comments

cl...@google.com <cl...@google.com> #2May 29, 2020 11:43AM

Assigned to ma...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

po...@google.com <po...@google.com> #3May 29, 2020 12:27PM

Reassigned to po...@google.com.

Thanks for the report!

ma...@google.com <ma...@google.com> #4May 29, 2020 02:10PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

po...@google.com <po...@google.com> Jun 1, 2020 07:47PM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Jun 1, 2020 07:48PM

deleted

Issue 157673259