Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ff4848986216d9dd04094f47c3356e83459cf657
Author: Mihai Popa <popam@google.com>
Date: Thu Jun 11 18:49:35 2020
Set LayoutNode-calculated AndroidViewHolder size
The CL sets the position calculated by layout nodes to the
AndroidViewHolder View x and y properties. This will ensure that the
holder will know its correct position, which can participate, for
example, to the calculation of globalPosition in onPositioned in nested
Compose content.
Bug: 158016274
Test: AndroidViewCompatTest
Change-Id: I2a0a1619b56240be8fc7ebb64b56d5fa5dc5dad9
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/test/AndroidViewCompatTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/node/ViewInterop.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/viewinterop/ComposedView.kt
https://android-review.googlesource.com/1340083
Branch: androidx-master-dev
commit ff4848986216d9dd04094f47c3356e83459cf657
Author: Mihai Popa <popam@google.com>
Date: Thu Jun 11 18:49:35 2020
Set LayoutNode-calculated AndroidViewHolder size
The CL sets the position calculated by layout nodes to the
AndroidViewHolder View x and y properties. This will ensure that the
holder will know its correct position, which can participate, for
example, to the calculation of globalPosition in onPositioned in nested
Compose content.
Bug: 158016274
Test: AndroidViewCompatTest
Change-Id: I2a0a1619b56240be8fc7ebb64b56d5fa5dc5dad9
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/test/AndroidViewCompatTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/node/ViewInterop.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/viewinterop/ComposedView.kt
Description
Meanwhile AndroidViewsHandler and AndroidOwner maybe doesn't set some of these and therefore AndroidOwner.calculatePosition doesn't work.
I tried to investigate more deeply but couldn't figure how how it all worked.
I'm not sure that this actually needs to be fixed, but I do need to make sure that pointer input data will always be accurate despite any parent moving around underneath the pointer, which requires that all pointers ultimately reference offests that are fixed to the screen, and thus I need to have accurate offsets from the screen.