Status Update
Comments
yb...@google.com <yb...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
sh...@google.com <sh...@google.com> #3
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
cc...@google.com <cc...@google.com> #4
ku...@gmail.com <ku...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com <ap...@google.com> #6
Branch: androidx-master-dev
commit a678d10f76e2c1da8f6857538474fbf87f919ed0
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Jun 02 18:09:39 2020
Rename merge adapter to concat adapter
Bug: 158019211
Test: existing tests
Change-Id: I71dbfc22d4c757cdc2c94ec25fc9a9b780431c2c
M paging/runtime/api/3.0.0-alpha02.txt
M paging/runtime/api/current.txt
M paging/runtime/api/public_plus_experimental_3.0.0-alpha02.txt
M paging/runtime/api/public_plus_experimental_current.txt
M paging/runtime/api/restricted_3.0.0-alpha02.txt
M paging/runtime/api/restricted_current.txt
M paging/runtime/build.gradle
M paging/runtime/src/main/java/androidx/paging/LoadStateAdapter.kt
M paging/runtime/src/main/java/androidx/paging/PagedListAdapter.kt
M paging/runtime/src/main/java/androidx/paging/PagingDataAdapter.kt
M recyclerview/recyclerview/api/1.2.0-alpha04.txt
M recyclerview/recyclerview/api/current.txt
M recyclerview/recyclerview/api/public_plus_experimental_1.2.0-alpha04.txt
M recyclerview/recyclerview/api/public_plus_experimental_current.txt
M recyclerview/recyclerview/api/restricted_1.2.0-alpha04.txt
M recyclerview/recyclerview/api/restricted_current.txt
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/ConcatAdapterSubject.kt
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/ConcatAdapterTest.kt
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/ConcatAdapter.java
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/ConcatAdapterController.java
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/NestedAdapterWrapper.java
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/RecyclerView.java
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/StableIdStorage.java
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/ViewTypeStorage.java
yb...@google.com <yb...@google.com>
ad...@google.com <ad...@google.com> #7
Years ago the term MergeAdapter was common for ListViews, but that was before other APIs like RxJava and Flow entered the common Android development lexicon and brought along much more precise definitions of these terms. These APIs build very strong distinctions between interleave (merge) and strict ordered sequence of groups (concat) and we benefit from consistency with the more contemporary usage here, especially when these APIs are often used in close proximity to one another.
Normally we try to encourage spelling out terms in API rather than abbreviating, but concat
is a special case here. String
, Rx and others standardized on concat
so long ago that many people aren't even familiar with the fully expanded term; better to be consistent with the ecosystem here.
ap...@google.com <ap...@google.com> #8
Branch: androidx-master-dev
commit c0540c10cc7ea5027d3fc3b22024de7e66c41a9d
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Jun 02 18:38:41 2020
ConcatAdapter API improvements
Accept extends bound in constructor arguments
Make Config & Config.Builder final
Bug: 158019211
Test: existing tests
Change-Id: I60bc0da651935b35a4dd64a0117aae532a278452
M recyclerview/recyclerview/api/1.2.0-alpha04.txt
M recyclerview/recyclerview/api/current.txt
M recyclerview/recyclerview/api/public_plus_experimental_1.2.0-alpha04.txt
M recyclerview/recyclerview/api/public_plus_experimental_current.txt
M recyclerview/recyclerview/api/restricted_1.2.0-alpha04.txt
M recyclerview/recyclerview/api/restricted_current.txt
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/ConcatAdapter.java
Description
Comment on Florina's blogpost (https://medium.com/p/294d2942127a ) mentioned that the name made it sound like it could interleave items, and I recently saw someone else make the same wrong assumption elsewhere.
Something like SequenceAdapter or ConcatAdapter or similar may be clearer.