Consider renaming MergeAdapter to clarify behavior [158019211]

Fixed

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Jun 2, 2020 08:07PM

Comment on Florina's blogpost (https://medium.com/p/294d2942127a) mentioned that the name made it sound like it could interleave items, and I recently saw someone else make the same wrong assumption elsewhere.

Something like SequenceAdapter or ConcatAdapter or similar may be clearer.

Comments

yb...@google.com <yb...@google.com> #2Jun 3, 2020 12:10AM

Reassigned to yb...@google.com.

My guess is an AutoValue extension is what's needed here:

http://ryanharter.com/blog/2016/05/16/autovalue-extensions/

We accept pull requests! :)

sh...@google.com <sh...@google.com> #3Jun 3, 2020 09:33PM

> We accept pull requests! :)

Is there a public repo somewhere? I don't see any obvious repo for it in

https://android.googlesource.com, and it doesn't seem to be inside

https://android.googlesource.com/platform/frameworks/support.

Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.

cc...@google.com <cc...@google.com> #4Jun 3, 2020 09:36PM

Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.

Sorry we don't have the source release yet :/.

ku...@gmail.com <ku...@gmail.com> #5Jun 5, 2020 09:13PM

"It is in the schedule but not high priority" -- completely understandable.

"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.

Thanks!

ap...@google.com <ap...@google.com> #6Jun 12, 2020 03:49PM

Add autovalue support also means you can easily achieve parcelable by

https://github.com/rharter/auto-value-parcel. Please consider support this.

yb...@google.com <yb...@google.com> Jun 12, 2020 03:50PM

Marked as fixed.

ad...@google.com <ad...@google.com> #7Jun 12, 2020 03:55PM

AutoValue is really a handy way to ensure data integrity.

ap...@google.com <ap...@google.com> #8Jun 12, 2020 04:57PM

Please add AutoValue support. AutoValue is a Google library with really good benefits such as toString() , hashCode() , AutoValue.Builder , checks at creation time if @NonNull values are null, etc.