Status Update
Comments
yb...@google.com <yb...@google.com> #2
Hi, thanks for reaching out to us! I'm currently looking into this issue you're seeing with startSeconds
. Will reach back with updates as soon as I have one.
sh...@google.com <sh...@google.com> #3
We are unable to reproduce this issue you're seeing with loadVideoById
. Can you share more details like the browser information and version in which you're able to see this?
cc...@google.com <cc...@google.com> #4
ku...@gmail.com <ku...@gmail.com> #5
I can easy reproduce this issue at your demo site.
This issue will not appear when you use the guest mode of Chrome.
You need signed in Chrome using Google(YouTube) acount.
How to reproduce at demo page
1. You play the inline video and stop at 8 min.
2. Set Content start time 60.
3. Push [Update Player with selected options]
4. The inline Player start at 8 min.
If you use guest mode of Chrome, the inline Player start at 1 min.
ap...@google.com <ap...@google.com> #6
Thanks for sharing all the information! I'm opening a report with the internal teams on your behalf. Will reach back with updates as soon as I have one.
yb...@google.com <yb...@google.com>
ad...@google.com <ad...@google.com> #7
Years ago the term MergeAdapter was common for ListViews, but that was before other APIs like RxJava and Flow entered the common Android development lexicon and brought along much more precise definitions of these terms. These APIs build very strong distinctions between interleave (merge) and strict ordered sequence of groups (concat) and we benefit from consistency with the more contemporary usage here, especially when these APIs are often used in close proximity to one another.
Normally we try to encourage spelling out terms in API rather than abbreviating, but concat
is a special case here. String
, Rx and others standardized on concat
so long ago that many people aren't even familiar with the fully expanded term; better to be consistent with the ecosystem here.
ap...@google.com <ap...@google.com> #8
Branch: androidx-master-dev
commit c0540c10cc7ea5027d3fc3b22024de7e66c41a9d
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Jun 02 18:38:41 2020
ConcatAdapter API improvements
Accept extends bound in constructor arguments
Make Config & Config.Builder final
Bug: 158019211
Test: existing tests
Change-Id: I60bc0da651935b35a4dd64a0117aae532a278452
M recyclerview/recyclerview/api/1.2.0-alpha04.txt
M recyclerview/recyclerview/api/current.txt
M recyclerview/recyclerview/api/public_plus_experimental_1.2.0-alpha04.txt
M recyclerview/recyclerview/api/public_plus_experimental_current.txt
M recyclerview/recyclerview/api/restricted_1.2.0-alpha04.txt
M recyclerview/recyclerview/api/restricted_current.txt
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/ConcatAdapter.java
Description
Comment on Florina's blogpost (https://medium.com/p/294d2942127a ) mentioned that the name made it sound like it could interleave items, and I recently saw someone else make the same wrong assumption elsewhere.
Something like SequenceAdapter or ConcatAdapter or similar may be clearer.