Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4ba20c0183e46f83483af4a8019ad6fb84d1c0c2
Author: Ian Lake <ilake@google.com>
Date: Wed Jun 03 10:46:12 2020
Request Insets only once the Fragment's View is attached
Instead of unconditionally calling
requestApplyInsets() directly before onViewCreated(),
we should always wait for the View to be attached
to its window so that requestApplyInsets() actually
works correctly for every Fragment.
This is a half step towards the final solution in
b/149024125 in delaying onViewCreated() until
the View is attached.
Test: tested in sample app
BUG: 158095749
Change-Id: Ie187051553437d77fd788ece52d8ec083e29f2e4
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1323649
Branch: androidx-master-dev
commit 4ba20c0183e46f83483af4a8019ad6fb84d1c0c2
Author: Ian Lake <ilake@google.com>
Date: Wed Jun 03 10:46:12 2020
Request Insets only once the Fragment's View is attached
Instead of unconditionally calling
requestApplyInsets() directly before onViewCreated(),
we should always wait for the View to be attached
to its window so that requestApplyInsets() actually
works correctly for every Fragment.
This is a half step towards the final solution in
the View is attached.
Test: tested in sample app
BUG: 158095749
Change-Id: Ie187051553437d77fd788ece52d8ec083e29f2e4
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
il...@google.com <il...@google.com> #3
This has been fixed internally and will be available in Fragment 1.3.0-alpha07
.
Description
Component used: Fragment Version used: 1.3.0-alpha05
Fragments call b/149024125 , this runs before the View is attached, meaning
ViewCompat.requestApplyInsets()
immediately before callingonViewCreated()
. However, due torequestApplyInsets()
doesn't actually do anything.We should consistently wait for the View to be attached before calling
requestApplyInsets()
.