Remove key parameter to composable functions, refactor metadata strategy [158123185]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

le...@google.com

created issue #1

Jun 3, 2020 09:43PM

Component used:
Version used:
Devices/Android versions reproduced on:

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Comments

le...@google.com <le...@google.com> Jul 21, 2020 10:02PM

Reassigned to ch...@google.com.

tc...@google.com <tc...@google.com> #2Aug 10, 2020 08:22PM

Following CLs are added to AndroidX:
-

https://r.android.com/2193004
-

https://r.android.com/2186213
-

https://r.android.com/2232128

ch...@google.com <ch...@google.com> #3Aug 10, 2020 08:30PM

Chromium counterpart:

https://crbug.com/1355297

tc...@google.com <tc...@google.com> #4Aug 10, 2020 09:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit a0fc2a2e7b8c8c09e36202915d836e67c3312253
Author: Abhijith Nair <abhijithnair@google.com>
Date: Mon Oct 03 13:11:02 2022

Add test for ProcessGlobalConfigActivity

Test ensures that there exists a data directory present on the device
with the name specified using `setDataDirectorySuffix(String, Context)`.

Bug: 250553687
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Change-Id: Ic1391ac6527fa78464ed4c9f685a067d6dcb3dc1

A webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/WebkitTestHelpers.java
M webkit/integration-tests/testapp/src/main/AndroidManifest.xml
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
A webkit/integration-tests/testapp/src/main/res/layout/activity_process_global_config.xml
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2239836

ap...@google.com <ap...@google.com> #5Aug 19, 2020 10:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit e59d4c20268f10741b4bfb0d939884704659043c
Author: Abhijith Nair <abhijithnair@google.com>
Date: Tue Oct 25 13:58:31 2022

Unhide ProcessGlobalConfig APIs

Along with unhiding the APIs, the API files are also updated.

Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Bug: 250553687
Relnote: "Add ProcessGlobalConfig enabling users to set process global
config prior to loading WebView."

Change-Id: I7c0e0e42e91efe45f16e66afead7b9e52240bfe4

M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/ProcessGlobalConfigActivityTestAppTest.java
M webkit/integration-tests/testapp/src/androidTest/java/com/example/androidx/webkit/WebkitTestHelpers.java
M webkit/integration-tests/testapp/src/main/java/com/example/androidx/webkit/ProcessGlobalConfigActivity.java
M webkit/webkit/api/current.txt
M webkit/webkit/api/public_plus_experimental_current.txt
M webkit/webkit/api/restricted_current.txt
M webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
M webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java
M webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java

https://android-review.googlesource.com/2268927

ap...@google.com <ap...@google.com> #6Aug 20, 2020 03:39PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit d1b0ecf7a695406a3a88da9a5f6c6b1859b784a9
Author: Abhijith Nair <abhijithnair@google.com>
Date: Tue Nov 01 18:07:17 2022

Rename the WebView manifest key name

Rename SET_DATA_DIRECTORY_SUFFIX:DEV to
STARTUP_FEATURE_SET_DATA_DIRECTORY_SUFFIX

Change-Id: Id2a0a29a3cbc6972bbf285836cd13e8d2af7fd3d
Test: ./gradlew webkit:integration-tests:testapp:connectedAndroidTest
Bug: 250553687

M webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java

https://android-review.googlesource.com/2280854

Issue 158123185