Remove key parameter to composable functions, refactor metadata strategy [158123185]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

le...@google.com

created issue #1

Jun 3, 2020 09:43PM

Component used:
Version used:
Devices/Android versions reproduced on:

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Comments

le...@google.com <le...@google.com> Jul 21, 2020 10:02PM

Reassigned to ch...@google.com.

tc...@google.com <tc...@google.com> #2Aug 10, 2020 08:22PM

Hi Chuck. This bug is currently on the Alpha hotlist but not on the Dev17 iteration. Can you please confirm whether it will be done by the cut this Wednesday? Thanks!

ch...@google.com <ch...@google.com> #3Aug 10, 2020 08:30PM

This will not make it to Alpha. The CL itself is done but the issues it uncovered will not be fixed in time.

tc...@google.com <tc...@google.com> #4Aug 10, 2020 09:06PM

Thanks for the update. I have moved this feature to post-Alpha.

ap...@google.com <ap...@google.com> #5Aug 19, 2020 10:16PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2d11462d2cfa01b28cc4d93fce12c244c774e51c
Author: Chuck Jazdzewski <chuckj@google.com>
Date: Tue Aug 18 14:33:35 2020

Fix placing source information into groups

When removing $key surfaced an issue where inserting source
information might incorrectly insert groups.

BUG: 158123185
Test: ControlFlowTransformTests, ./gradlew :c:c-c-h:i:tDUT
Change-Id: I11c0f01596352e8fa9c64aee4178886122d26cb5

M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/ComposerParamTransformTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/ControlFlowTransformTests.kt
M compose/compose-compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposableFunctionBodyTransformer.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/ComposeViewAdapterTest.kt
M ui/ui-tooling/src/main/java/androidx/ui/tooling/preview/ComposeViewAdapter.kt

https://android-review.googlesource.com/1403994

ap...@google.com <ap...@google.com> #6Aug 20, 2020 03:39PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1d8872cf4f7aad93ede3277bb1627bfab188c113
Author: Chuck Jazdzewski <chuckj@google.com>
Date: Thu Jul 30 13:37:18 2020

Remove the `$key` parameter from the compose ABI

This change removes the `$key` parameter as the `$key`
parameter is no longer necessary due to a change in how
source information is collected.

Also this change makes the compiler tests less noisy and
modified the restart alloaiton tracking to account for the
allocation of a source information string.

Fixes:

b/158123185

Test: updated tests to pass with compiler changes

Relnote: """The calling convention for composable functions has
changed. This is a binary breaking change. All libraries must be
recompiled to work with this version of the compose compiler plugin.

This change does not create a source level breaking change as the
only APIs that have changed are compiler APIs that have an explicit
opt in.
"""

Change-Id: I7afd2d7b19652ec92b8d6d1d1e92f0745968aa66

M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/AbstractCodegenSignatureTest.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/AbstractIrTransformTest.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/AbstractLoweringTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/ComposeMultiPlatformTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/ComposerParamSignatureTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/ComposerParamTransformTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/ControlFlowTransformTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/ControlFlowTransformTestsNoSource.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/DefaultParamTransformTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/FunctionBodySkippingTransformTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/KtxCrossModuleTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/LambdaMemoizationTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/LambdaMemoizationTransformTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/LiveLiteralCodegenTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/RememberIntrinsicTransformTests.kt
M compose/compose-compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/RobolectricComposeTester.kt
M compose/compose-compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/KtxNameConventions.kt
M compose/compose-compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposableFunctionBodyTransformer.kt
M compose/compose-compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposableTypeRemapper.kt
M compose/compose-compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposerIntrinsicTransformer.kt
M compose/compose-compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposerLambdaMemoization.kt
M compose/compose-compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposerParamTransformer.kt
M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/androidAndroidTest/kotlin/androidx/compose/runtime/RestartTests.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/internal/ComposableLambda.kt
M compose/runtime/runtime/src/jvmMain/kotlin/androidx/compose/runtime/internal/ComposableLambdaN.kt
M compose/runtime/runtime/src/test/kotlin/androidx/compose/runtime/mock/ViewApplier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/ComposedModifier.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/ComposedModifierTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/BoundsTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/inspector/InlineClassConverterTest.kt
M ui/ui-tooling/src/main/java/androidx/ui/tooling/preview/PreviewUtils.kt

https://android-review.googlesource.com/1380293

Issue 158123185