Fixed
Status Update
Comments
po...@google.com <po...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 08c4795b55d497db47c21753ce4723d74f989aef
Author: Mihai Popa <popam@google.com>
Date: Thu Jun 04 20:01:27 2020
Return non-null from Placeable#get(AlignmentLine)
Relnote: Alignment line Int positions returned from Placeable#get(AlignmentLine) are now non-null. If the queried alignment line is missing, AlignmentLine.Unspecified will be returned.
Bug: 158134875
Test: built and ran core, layout and material tests
Change-Id: I896c5ef8a18919aa84413669341e716bf676e32e
M ui/ui-core/api/0.1.0-dev14.txt
M ui/ui-core/api/api_lint.ignore
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev14.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AlignmentLine.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/DelegatingLayoutNodeWrapper.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/InnerPlaceable.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/Layout.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/LayoutCoordinates.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/LayoutModifier.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/Measured.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/ModifiedLayoutNode.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/OuterMeasurablePlaceable.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/Placeable.kt
M ui/ui-core/src/unitTest/kotlin/androidx/ui/core/pointerinput/HitPathTrackerTest.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/AlignmentLine.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/RowColumnImpl.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/AppBarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/BottomNavigationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ListItemTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/TabTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/TextFieldTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/Snackbar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextField.kt
https://android-review.googlesource.com/1324516
Branch: androidx-master-dev
commit 08c4795b55d497db47c21753ce4723d74f989aef
Author: Mihai Popa <popam@google.com>
Date: Thu Jun 04 20:01:27 2020
Return non-null from Placeable#get(AlignmentLine)
Relnote: Alignment line Int positions returned from Placeable#get(AlignmentLine) are now non-null. If the queried alignment line is missing, AlignmentLine.Unspecified will be returned.
Bug: 158134875
Test: built and ran core, layout and material tests
Change-Id: I896c5ef8a18919aa84413669341e716bf676e32e
M ui/ui-core/api/0.1.0-dev14.txt
M ui/ui-core/api/api_lint.ignore
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev14.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AlignmentLine.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/DelegatingLayoutNodeWrapper.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/InnerPlaceable.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/Layout.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/LayoutCoordinates.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/LayoutModifier.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/Measured.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/ModifiedLayoutNode.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/OuterMeasurablePlaceable.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/Placeable.kt
M ui/ui-core/src/unitTest/kotlin/androidx/ui/core/pointerinput/HitPathTrackerTest.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/AlignmentLine.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/RowColumnImpl.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/AppBarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/BottomNavigationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ListItemTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/TabTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/TextFieldTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/Snackbar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextField.kt
Description
Our linter is now warning us that Placeable.get(AlignmentLine): Int? should not box Ints. It is correct and we should fix this by perhaps using a sentinel value to replace
null
.