Border API feedback [158160576]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Jun 4, 2020 10:16AM

From compose API council:

Border discussion notes

Remove Border data class used by Box?
- Duplicates functionality found elsewhere
Rename Modifier.outline to Modifier.border *This modifier should affect layout and pad in the layout by the size of the border
How do I know how to write an API when these are the potential moving parts:
- Border class
- Shape
- Parameters
- Modifier
Decision!
- Rename Border data class to Stroke
- Remove Modifier.drawBorder modifiers, replace with Modifier.border() * border modifier should also incorporate layout and clip+shape modification
- border parameter on Box becomes "border: Stroke? = null"
- Stroke should have a Color-based convenience factory/constructor *Nice effects: * OutlinedButton now has a shape and a stroke; not conflating the "border" conceptual space * "border" is now a unified concept of shape+stroke parameters+padding+clip behavior * "border" never appears as a parameter; encourage that usage as a modifier * "outline" is part of the OutlinedButton's content

Comments

ja...@google.com <ja...@google.com> #2Jul 31, 2020 12:08PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

ma...@google.com <ma...@google.com> #3Jul 31, 2020 12:18PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ap...@google.com <ap...@google.com> #4Aug 11, 2020 05:38PM

Marked as fixed.

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

Issue 158160576

Description

Issue summary

Comments

ja...@google.com <ja...@google.com> #2Jul 31, 2020 12:08PM

ma...@google.com <ma...@google.com> #3Jul 31, 2020 12:18PM

ap...@google.com <ap...@google.com> #4Aug 11, 2020 05:38PM

Add comment

Issue metadata